Merge branch 'fix/_iter_chunk_keys' of github.com:d-v-b/zarr-python into fix/_iter_chunk_keys

Author: d-v-b

.github/workflows/check_changelogs.yml

@@ -0,0 +1,18 @@
+name: Check changelog entries
+
+on:
+  pull_request:
+
+jobs:
+  check-changelogs:
+    name: Check changelog entries
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
+
+      - name: Check changelog entries
+        run: uv run --no-sync python ci/check_changelog_entries.py

changes/3251.fix.rst renamed to changes/3251.bugfix.rst

@@ -0,0 +1,51 @@
+"""
+Check changelog entries have the correct filename structure.
+"""
+
+import sys
+from pathlib import Path
+
+VALID_CHANGELOG_TYPES = ["feature", "bugfix", "doc", "removal", "misc"]
+CHANGELOG_DIRECTORY = (Path(__file__).parent.parent / "changes").resolve()
+
+
+def is_int(s: str) -> bool:
+    try:
+        int(s)
+    except ValueError:
+        return False
+    else:
+        return True
+
+
+if __name__ == "__main__":
+    print(f"Looking for changelog entries in {CHANGELOG_DIRECTORY}")
+    entries = CHANGELOG_DIRECTORY.glob("*")
+    entries = [e for e in entries if e.name not in [".gitignore", "README.md"]]
+    print(f"Found {len(entries)} entries")
+    print()
+
+    bad_suffix = [e for e in entries if e.suffix != ".rst"]
+    bad_issue_no = [e for e in entries if not is_int(e.name.split(".")[0])]
+    bad_type = [e for e in entries if e.name.split(".")[1] not in VALID_CHANGELOG_TYPES]
+
+    if len(bad_suffix) or len(bad_issue_no) or len(bad_type):
+        if len(bad_suffix):
+            print("Changelog entries without .rst suffix")
+            print("-------------------------------------")
+            print("\n".join([p.name for p in bad_suffix]))
+            print()
+        if len(bad_issue_no):
+            print("Changelog entries without integer issue number")
+            print("----------------------------------------------")
+            print("\n".join([p.name for p in bad_issue_no]))
+            print()
+        if len(bad_type):
+            print("Changelog entries without valid type")
+            print("------------------------------------")
+            print("\n".join([p.name for p in bad_type]))
+            print(f"Valid types are: {VALID_CHANGELOG_TYPES}")
+            print()
+        sys.exit(1)
+
+    sys.exit(0)

changes/+c563f4d4.bugfix.rst renamed to changes/3258.bugfix.rst

@@ -70,7 +70,7 @@ gpu = [
 ]
 # Development extras
 test = [
-    "coverage",
+    "coverage>=7.10",
     # Pin possibly due to https://github.com/pytest-dev/pytest-cov/issues/693
     "pytest<8.4",
     "pytest-asyncio",
@@ -128,11 +128,8 @@ dev = [
 ]
 
 [tool.coverage.report]
-exclude_lines = [
-    "pragma: no cover",
-    "if TYPE_CHECKING:",
-    "pragma: ${PY_MAJOR_VERSION} no cover",
-    '.*\.\.\.' # Ignore "..." lines
+exclude_also = [
+    'if TYPE_CHECKING:',
 ]
 
 [tool.coverage.run]

changes/3264.fix.rst renamed to changes/3264.bugfix.rst

@@ -38,6 +38,9 @@
     VariableLengthUTF8JSON_V2,
     ZDType,
     data_type_registry,
+    # Import for backwards compatibility, but not included in __all__
+    # so it doesn't show up in the docs
+    parse_data_type,  # noqa: F401
     parse_dtype,
 )
 

changes/3280.fix.rst renamed to changes/3280.bugfix.rst

@@ -13,18 +13,20 @@
 from zarr.core.config import config
 from zarr.core.dtype import (
     AnyDType,
-    Bool,
     DataTypeRegistry,
-    FixedLengthUTF32,
     TBaseDType,
     TBaseScalar,
+    get_data_type_from_json,
+)
+from zarr.core.dtype.common import unpack_dtype_json
+from zarr.dtype import (  # type: ignore[attr-defined]
+    Bool,
+    FixedLengthUTF32,
     ZDType,
     data_type_registry,
-    get_data_type_from_json,
     parse_data_type,
     parse_dtype,
 )
-from zarr.core.dtype.common import unpack_dtype_json
 
 if TYPE_CHECKING:
     from collections.abc import Generator