Skip to content

Commit 950f6d8

Browse files
committed
review comments
1 parent b5cbf25 commit 950f6d8

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

changes/2804.feature.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
:py:class:`LocalStore` learned to ``delete_dir``.
1+
:py:class:`LocalStore` learned to ``delete_dir``. This makes array and group deletes more efficient.

tests/test_store/test_stateful.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,8 @@ def mk_test_instance_sync() -> None:
2929
pytest.skip(reason="ZipStore does not support delete")
3030

3131
if isinstance(sync_store, LocalStore):
32+
# This test uses arbitrary keys, which are passed to `set` and `delete`.
33+
# It assumes that `set` and `delete` are the only two operations that modify state.
34+
# But LocalStore, directories can hang around even after a key is delete-d.
3235
pytest.skip(reason="Test isn't suitable for LocalStore.")
3336
run_state_machine_as_test(mk_test_instance_sync)

0 commit comments

Comments
 (0)