simplify group tests by removing zip and remote store cases

Author: d-v-b

tests/test_group.py

@@ -36,7 +36,7 @@ def exists_ok(request: pytest.FixtureRequest) -> bool:
     return result
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_init(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test that initializing a group from an asyncgroup works.
@@ -46,7 +46,7 @@ def test_group_init(store: Store, zarr_format: ZarrFormat) -> None:
     assert group._async_group == agroup
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_create_creates_parents(store: Store, zarr_format: ZarrFormat) -> None:
     # prepare a root node, with some data set
     await zarr.api.asynchronous.open_group(
@@ -99,7 +99,7 @@ async def test_create_creates_parents(store: Store, zarr_format: ZarrFormat) ->
             assert g.attrs == {}
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_name_properties(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test basic properties of groups
@@ -120,7 +120,7 @@ def test_group_name_properties(store: Store, zarr_format: ZarrFormat) -> None:
     assert bar.basename == "bar"
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 @pytest.mark.parametrize("consolidated_metadata", [True, False])
 def test_group_members(store: Store, zarr_format: ZarrFormat, consolidated_metadata: bool) -> None:
     """
@@ -203,7 +203,7 @@ def test_group_members(store: Store, zarr_format: ZarrFormat, consolidated_metad
         members_observed = group.members(max_depth=-1)
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test basic Group routines.
@@ -246,7 +246,7 @@ def test_group(store: Store, zarr_format: ZarrFormat) -> None:
     assert dict(bar3.attrs) == {"baz": "qux", "name": "bar"}
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_create(store: Store, exists_ok: bool, zarr_format: ZarrFormat) -> None:
     """
     Test that `Group.from_store` works as expected.
@@ -263,7 +263,7 @@ def test_group_create(store: Store, exists_ok: bool, zarr_format: ZarrFormat) ->
             _ = Group.from_store(store, exists_ok=exists_ok, zarr_format=zarr_format)
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_open(store: Store, zarr_format: ZarrFormat, exists_ok: bool) -> None:
     """
     Test the `Group.open` method.
@@ -301,7 +301,7 @@ def test_group_open(store: Store, zarr_format: ZarrFormat, exists_ok: bool) -> N
 
 
 @pytest.mark.parametrize("consolidated", [True, False])
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_getitem(store: Store, zarr_format: ZarrFormat, consolidated: bool) -> None:
     """
     Test the `Group.__getitem__` method.
@@ -358,7 +358,7 @@ def test_group_getitem(store: Store, zarr_format: ZarrFormat, consolidated: bool
             group["subarray/subsubarray"]
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_get_with_default(store: Store, zarr_format: ZarrFormat) -> None:
     group = Group.from_store(store, zarr_format=zarr_format)
 
@@ -379,7 +379,7 @@ def test_group_get_with_default(store: Store, zarr_format: ZarrFormat) -> None:
 
 
 @pytest.mark.parametrize("consolidated", [True, False])
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_delitem(store: Store, zarr_format: ZarrFormat, consolidated: bool) -> None:
     """
     Test the `Group.__delitem__` method.
@@ -409,7 +409,7 @@ def test_group_delitem(store: Store, zarr_format: ZarrFormat, consolidated: bool
         group["subarray"]
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_iter(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test the `Group.__iter__` method.
@@ -419,7 +419,7 @@ def test_group_iter(store: Store, zarr_format: ZarrFormat) -> None:
     assert list(group) == []
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_len(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test the `Group.__len__` method.
@@ -429,7 +429,7 @@ def test_group_len(store: Store, zarr_format: ZarrFormat) -> None:
     assert len(group) == 0
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_setitem(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test the `Group.__setitem__` method.
@@ -456,7 +456,7 @@ def test_group_setitem(store: Store, zarr_format: ZarrFormat) -> None:
     np.testing.assert_array_equal(group[key], arr)
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_contains(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test the `Group.__contains__` method
@@ -467,7 +467,7 @@ def test_group_contains(store: Store, zarr_format: ZarrFormat) -> None:
     assert "foo" in group
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 @pytest.mark.parametrize("consolidate", [True, False])
 def test_group_child_iterators(store: Store, zarr_format: ZarrFormat, consolidate: bool):
     group = Group.from_store(store, zarr_format=zarr_format)
@@ -573,7 +573,7 @@ def test_group_child_iterators(store: Store, zarr_format: ZarrFormat, consolidat
     assert sorted(group.array_values(), key=lambda x: x.name) == expected_array_values
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_update_attributes(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test the behavior of `Group.update_attributes`
@@ -587,7 +587,7 @@ def test_group_update_attributes(store: Store, zarr_format: ZarrFormat) -> None:
 
 
 @pytest.mark.parametrize("method", ["create_array", "array"])
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_create_array(
     store: Store,
     zarr_format: ZarrFormat,
@@ -622,7 +622,7 @@ def test_group_create_array(
     assert np.array_equal(array[:], data)
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_group_array_creation(
     store: Store,
     zarr_format: ZarrFormat,
@@ -691,9 +691,7 @@ def test_group_array_creation(
     assert full_like_array.store_path.store == store
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
-@pytest.mark.parametrize("zarr_format", [2, 3])
-@pytest.mark.parametrize("exists_ok", [True, False])
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 @pytest.mark.parametrize("extant_node", ["array", "group"])
 def test_group_creation_existing_node(
     store: Store,
@@ -740,7 +738,7 @@ def test_group_creation_existing_node(
             )
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_create(
     store: Store,
     exists_ok: bool,
@@ -783,15 +781,15 @@ async def test_asyncgroup_create(
             )
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_attrs(store: Store, zarr_format: ZarrFormat) -> None:
     attributes = {"foo": 100}
     agroup = await AsyncGroup.from_store(store, zarr_format=zarr_format, attributes=attributes)
 
     assert agroup.attrs == agroup.metadata.attributes == attributes
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_info(store: Store, zarr_format: ZarrFormat) -> None:
     agroup = await AsyncGroup.from_store(  # noqa: F841
         store,
@@ -801,7 +799,7 @@ async def test_asyncgroup_info(store: Store, zarr_format: ZarrFormat) -> None:
     # assert agroup.info == agroup.metadata.info
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_open(
     store: Store,
     zarr_format: ZarrFormat,
@@ -823,7 +821,7 @@ async def test_asyncgroup_open(
     assert group_w == group_r
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_open_wrong_format(
     store: Store,
     zarr_format: ZarrFormat,
@@ -844,7 +842,7 @@ async def test_asyncgroup_open_wrong_format(
 
 # todo: replace the dict[str, Any] type with something a bit more specific
 # should this be async?
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 @pytest.mark.parametrize(
     "data",
     [
@@ -867,7 +865,7 @@ def test_asyncgroup_from_dict(store: Store, data: dict[str, Any]) -> None:
 # todo: replace this with a declarative API where we model a full hierarchy
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_getitem(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Create an `AsyncGroup`, then create members of that group, and ensure that we can access those
@@ -890,7 +888,7 @@ async def test_asyncgroup_getitem(store: Store, zarr_format: ZarrFormat) -> None
         await agroup.getitem("foo")
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_delitem(store: Store, zarr_format: ZarrFormat) -> None:
     if not store.supports_deletes:
         pytest.skip("store does not support deletes")
@@ -927,7 +925,7 @@ async def test_asyncgroup_delitem(store: Store, zarr_format: ZarrFormat) -> None
         raise AssertionError
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_create_group(
     store: Store,
     zarr_format: ZarrFormat,
@@ -944,7 +942,7 @@ async def test_asyncgroup_create_group(
     assert subnode.metadata.zarr_format == zarr_format
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_create_array(
     store: Store, zarr_format: ZarrFormat, exists_ok: bool
 ) -> None:
@@ -984,7 +982,7 @@ async def test_asyncgroup_create_array(
     assert subnode.metadata.zarr_format == zarr_format
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_asyncgroup_update_attributes(store: Store, zarr_format: ZarrFormat) -> None:
     """
     Test that the AsyncGroup.update_attributes method works correctly.
@@ -999,8 +997,7 @@ async def test_asyncgroup_update_attributes(store: Store, zarr_format: ZarrForma
     assert agroup_new_attributes.attrs == attributes_new
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
-@pytest.mark.parametrize("zarr_format", [2, 3])
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_serializable_async_group(store: LocalStore, zarr_format: ZarrFormat) -> None:
     expected = await AsyncGroup.from_store(
         store=store, attributes={"foo": 999}, zarr_format=zarr_format
@@ -1010,8 +1007,7 @@ async def test_serializable_async_group(store: LocalStore, zarr_format: ZarrForm
     assert actual == expected
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
-@pytest.mark.parametrize("zarr_format", [2, 3])
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 def test_serializable_sync_group(store: LocalStore, zarr_format: ZarrFormat) -> None:
     expected = Group.from_store(store=store, attributes={"foo": 999}, zarr_format=zarr_format)
     p = pickle.dumps(expected)
@@ -1020,7 +1016,7 @@ def test_serializable_sync_group(store: LocalStore, zarr_format: ZarrFormat) ->
 
 
 @pytest.mark.parametrize("consolidated_metadata", [True, False])
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_group_members_async(store: Store, consolidated_metadata: bool) -> None:
     group = await AsyncGroup.from_store(
         store=store,
@@ -1096,7 +1092,7 @@ async def test_group_members_async(store: Store, consolidated_metadata: bool) ->
         assert nmembers == 4
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_require_group(store: Store, zarr_format: ZarrFormat) -> None:
     root = await AsyncGroup.from_store(store=store, zarr_format=zarr_format)
 
@@ -1127,7 +1123,7 @@ async def test_require_group(store: Store, zarr_format: ZarrFormat) -> None:
         await foo_group.require_group("bar")
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_require_groups(store: Store, zarr_format: ZarrFormat) -> None:
     root = await AsyncGroup.from_store(store=store, zarr_format=zarr_format)
     # create foo group
@@ -1149,7 +1145,7 @@ async def test_require_groups(store: Store, zarr_format: ZarrFormat) -> None:
     assert no_group == ()
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_create_dataset(store: Store, zarr_format: ZarrFormat) -> None:
     root = await AsyncGroup.from_store(store=store, zarr_format=zarr_format)
     with pytest.warns(DeprecationWarning):
@@ -1164,7 +1160,7 @@ async def test_create_dataset(store: Store, zarr_format: ZarrFormat) -> None:
         await root.create_dataset("bar", shape=(100,), dtype="int8")
 
 
-@pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
 async def test_require_array(store: Store, zarr_format: ZarrFormat) -> None:
     root = await AsyncGroup.from_store(store=store, zarr_format=zarr_format)
     foo1 = await root.require_array("foo", shape=(10,), dtype="i8", attributes={"foo": 101})
@@ -1246,7 +1242,7 @@ def test_open_mutable_mapping_sync():
 
 
 class TestConsolidated:
-    @pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+    @pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
     async def test_group_getitem_consolidated(self, store: Store) -> None:
         root = await AsyncGroup.from_store(store=store)
         # Set up the test structure with
@@ -1297,7 +1293,7 @@ async def test_group_getitem_consolidated(self, store: Store) -> None:
         rg2 = await rg1.getitem("g2")
         assert rg2.metadata.consolidated_metadata == ConsolidatedMetadata(metadata={})
 
-    @pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+    @pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
     async def test_group_delitem_consolidated(self, store: Store) -> None:
         if isinstance(store, ZipStore):
             raise pytest.skip("Not implemented")
@@ -1334,7 +1330,7 @@ async def test_group_delitem_consolidated(self, store: Store) -> None:
         assert len(group.metadata.consolidated_metadata.metadata) == 1
         assert "g0" not in group.metadata.consolidated_metadata.metadata
 
-    @pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+    @pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
     def test_open_consolidated_raises(self, store: Store) -> None:
         if isinstance(store, ZipStore):
             raise pytest.skip("Not implemented")
@@ -1355,7 +1351,7 @@ def test_open_consolidated_raises(self, store: Store) -> None:
         group = zarr.open_group(store=store, use_consolidated=False)
         assert group.metadata.consolidated_metadata is None
 
-    @pytest.mark.parametrize("store", ["local", "memory", "remote", "zip"], indirect=True)
+    @pytest.mark.parametrize("store", ["local", "memory"], indirect=True)
     async def test_open_consolidated_raises_async(self, store: Store) -> None:
         if isinstance(store, ZipStore):
             raise pytest.skip("Not implemented")