Skip to content

Commit a95d54a

Browse files
authored
Apply suggestions from code review
1 parent 322918a commit a95d54a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/zarr/api/asynchronous.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ async def open_group(
598598
if chunk_store is not None:
599599
warnings.warn("chunk_store is not yet implemented", RuntimeWarning, stacklevel=2)
600600

601-
store_path = await make_store_path(store, mode=mode)
601+
store_path = await make_store_path(store, mode=mode, storage_options=storage_options)
602602
if path is not None:
603603
store_path = store_path / path
604604

src/zarr/core/array.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ async def create(
197197
fill_value: Any | None = None,
198198
attributes: dict[str, JSON] | None = None,
199199
# v3 only
200-
chunk_shape: ChunkCoords | None = None, # TODO: handle bool and iterable of iterable types
200+
chunk_shape: ChunkCoords | None = None,
201201
chunk_key_encoding: (
202202
ChunkKeyEncoding
203203
| tuple[Literal["default"], Literal[".", "/"]]
@@ -207,7 +207,7 @@ async def create(
207207
codecs: Iterable[Codec | dict[str, JSON]] | None = None,
208208
dimension_names: Iterable[str] | None = None,
209209
# v2 only
210-
chunks: ShapeLike | None = None, # TODO: handle bool and iterable of iterable types
210+
chunks: ShapeLike | None = None,
211211
dimension_separator: Literal[".", "/"] | None = None,
212212
order: Literal["C", "F"] | None = None,
213213
filters: list[dict[str, JSON]] | None = None,

0 commit comments

Comments
 (0)