avoid inserting order for v3 arrays in _like_args

Author: d-v-b

src/zarr/api/asynchronous.py

@@ -52,8 +52,6 @@
 if TYPE_CHECKING:
     from collections.abc import Iterable
 
-    import numcodecs
-
     from zarr.abc.codec import Codec
     from zarr.abc.numcodec import Numcodec
     from zarr.core.buffer import NDArrayLikeOrScalar
@@ -128,11 +126,11 @@ def _get_shape_chunks(a: ArrayLike | Any) -> tuple[tuple[int, ...] | None, tuple
 
 
 class _LikeArgs(TypedDict):
-    shape: NotRequired[ChunkCoords]
-    chunks: NotRequired[ChunkCoords]
+    shape: NotRequired[tuple[int, ...]]
+    chunks: NotRequired[tuple[int, ...]]
     dtype: NotRequired[np.dtype[np.generic]]
     order: NotRequired[Literal["C", "F"]]
-    filters: NotRequired[tuple[numcodecs.abc.Codec, ...] | None]
+    filters: NotRequired[tuple[Numcodec, ...] | None]
     compressor: NotRequired[CompressorLikev2]
     codecs: NotRequired[tuple[Codec, ...]]
 
@@ -151,9 +149,9 @@ def _like_args(a: ArrayLike) -> _LikeArgs:
     if hasattr(a, "dtype"):
         new["dtype"] = a.dtype
 
-    if isinstance(a, AsyncArray):
-        new["order"] = a.order
+    if isinstance(a, AsyncArray | Array):
         if isinstance(a.metadata, ArrayV2Metadata):
+            new["order"] = a.order
             new["compressor"] = a.metadata.compressor
             new["filters"] = a.metadata.filters
         else:

tests/test_api.py

@@ -160,7 +160,7 @@ async def test_array_like_creation(
     else:
         expect_dtype = ref_arr.dtype  # type: ignore[assignment]
 
-    new_arr = await func(ref_arr, path="foo", **kwargs)  # type: ignore[call-arg]
+    new_arr = await func(ref_arr, path="foo", zarr_format=zarr_format, **kwargs)  # type: ignore[call-arg]
     assert new_arr.shape == expect_shape
     assert new_arr.chunks == expect_chunks
     assert new_arr.dtype == expect_dtype

tests/test_api/test_asynchronous.py

@@ -88,7 +88,7 @@ def test_like_args(
     """
     Test the like_args function
     """
-    assert _like_args(observed, {}) == expected
+    assert _like_args(observed) == expected
 
 
 async def test_open_no_array() -> None: