more coverage

Author: Martin Durant

zarr/creation.py

@@ -133,7 +133,7 @@ def normalize_store_arg(store, clobber=False, default=dict, storage_options=None
     elif isinstance(store, str):
         mode = 'w' if clobber else 'r'
         if "://" in store or "::" in store:
-            return FSStore(store, **(storage_options or {}))
+            return FSStore(store, mode=mode, **(storage_options or {}))
         elif storage_options:
             raise ValueError("storage_options passed with non-fsspec path")
         if store.endswith('.zip'):

zarr/tests/test_storage.py

@@ -871,6 +871,12 @@ def test_consolidated(self):
             store2[".zarray"] = b"{{}}"
         with pytest.raises(PermissionError):
             del store2[".zarray"]
+        with pytest.raises(PermissionError):
+            store2.clear()
+        with pytest.raises(PermissionError):
+            store2.rmdir("any")
+        with pytest.raises(ValueError):
+            FSStore(os.path.join(path, ".zmetadata"))
 
         store.clear()
         assert ".zmetadata" not in store
@@ -882,6 +888,7 @@ def test_not_fsspec(self):
             zarr.open_array(path, mode='w', storage_options={"some": "kwargs"})
         with pytest.raises(ValueError, match="storage_options"):
             zarr.open_group(path, mode='w', storage_options={"some": "kwargs"})
+        zarr.open_array("file://" + path, mode='w', shape=(1,), dtype="f8")
 
 
 class TestNestedDirectoryStore(TestDirectoryStore, unittest.TestCase):