update typeddicts, and handle location in crc32c codec json

Author: d-v-b

src/zarr/codecs/crc32c_.py

@@ -20,18 +20,27 @@
     from zarr.core.buffer import Buffer
 
 
-class Crc32cConfig(TypedDict): ...
+class Crc32cConfig_V2(TypedDict):
+    location: ReadOnly[Literal["start", "end"]]
 
 
-class Crc32cJSON_V2(TypedDict):
+class Crc32cConfig_V3(TypedDict): ...
+
+
+class Crc32cJSON_V2(Crc32cConfig_V2):
     id: ReadOnly[Literal["crc32c"]]
 
 
-class Crc32cJSON_V3(NamedConfig[Literal["crc32c"], Crc32cConfig]): ...
+class Crc32cJSON_V3(NamedConfig[Literal["crc32c"], Crc32cConfig_V3]): ...
 
 
 def check_json_v2(data: object) -> TypeGuard[Crc32cJSON_V2]:
-    return isinstance(data, Mapping) and set(data.keys()) == {"id"} and data["id"] == "crc32c"
+    return (
+        isinstance(data, Mapping)
+        and set(data.keys()) == {"id", "location"}
+        and data["id"] == "crc32c"
+        and data["location"] in ("start", "end")
+    )
 
 
 def check_json_v3(data: object) -> TypeGuard[Crc32cJSON_V3]:
@@ -55,6 +64,8 @@ def from_dict(cls, data: dict[str, JSON]) -> Self:
     @classmethod
     def _from_json_v2(cls, data: CodecJSON) -> Self:
         if check_json_v2(data):
+            if data["location"] != "end":
+                raise ValueError('The crc32c codec only supports the "end" location')
             return cls()
         msg = (
             "Invalid Zarr V2 JSON representation of the crc32c codec. "

src/zarr/codecs/numcodecs/_codecs.py

@@ -71,7 +71,7 @@
 
     from zarr.abc.numcodec import Numcodec
     from zarr.codecs.blosc import BloscJSON_V2, BloscJSON_V3
-    from zarr.codecs.crc32c_ import Crc32cConfig, Crc32cJSON_V2, Crc32cJSON_V3
+    from zarr.codecs.crc32c_ import Crc32cConfig_V2, Crc32cJSON_V2, Crc32cJSON_V3
     from zarr.codecs.gzip import GZipConfig, GZipJSON_V2, GZipJSON_V3
     from zarr.codecs.zstd import ZstdConfig_V3, ZstdJSON_V2, ZstdJSON_V3
     from zarr.core.array_spec import ArraySpec
@@ -253,6 +253,8 @@ class AsTypeJSON_V3(NamedRequiredConfig[Literal["astype"], AsTypeConfig]):
 class Crc32Config(TypedDict):
     """Configuration parameters for CRC32 codec."""
 
+    location: Literal["start", "end"]
+
 
 class Crc32JSON_V2(Crc32Config):
     """JSON representation of CRC32 codec for Zarr V2."""
@@ -267,6 +269,8 @@ class Crc32JSON_V3(NamedConfig[Literal["crc32"], Crc32Config]):
 class Adler32Config(TypedDict):
     """Configuration parameters for Adler32 codec."""
 
+    location: Literal["start", "end"]
+
 
 class Adler32JSON_V2(Adler32Config):
     """JSON representation of Adler32 codec for Zarr V2."""
@@ -295,6 +299,9 @@ class Fletcher32JSON_V3(NamedRequiredConfig[Literal["fletcher32"], Fletcher32Con
 class JenkinsLookup3Config(TypedDict):
     """Configuration parameters for JenkinsLookup3 codec."""
 
+    initval: int
+    prefix: bytes
+
 
 class JenkinsLookup3JSON_V2(JenkinsLookup3Config):
     """JSON representation of JenkinsLookup3 codec for Zarr V2."""
@@ -747,7 +754,7 @@ def to_json(self, zarr_format: ZarrFormat) -> Crc32JSON_V2 | Crc32JSON_V3:
 class CRC32C(_NumcodecsChecksumCodec):
     codec_name = "numcodecs.crc32c"
     _codec_id = "crc32c"
-    codec_config: Crc32cConfig
+    codec_config: Crc32cConfig_V2
 
     @overload
     def to_json(self, zarr_format: Literal[2]) -> Crc32cJSON_V2: ...