Skip to content

Commit cafb46a

Browse files
committed
fixup
1 parent fce2600 commit cafb46a

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

src/zarr/storage/logging.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,3 @@ def with_mode(self, mode: AccessModeLiteral) -> Self:
235235
log_level=self.log_level,
236236
log_handler=self.log_handler,
237237
)
238-
239-
240-
# TODO: wrap delete methods here

src/zarr/testing/store.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,12 @@ async def test_delete_dir(self, store: S) -> None:
224224
if not store.supports_deletes:
225225
pytest.skip("store does not support deletes")
226226
await store.set("zarr.json", self.buffer_cls.from_bytes(b"root"))
227+
await store.set("foo-bar/zarr.json", self.buffer_cls.from_bytes(b"root"))
227228
await store.set("foo/zarr.json", self.buffer_cls.from_bytes(b"bar"))
228229
await store.set("foo/c/0", self.buffer_cls.from_bytes(b"chunk"))
229230
await store.delete_dir("foo")
230231
assert await store.exists("zarr.json")
232+
assert await store.exists("foo-bar/zarr.json")
231233
assert not await store.exists("foo/zarr.json")
232234
assert not await store.exists("foo/c/0")
233235

tests/test_array.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ def test_array_creation_existing_node(
5252

5353
if exists_ok:
5454
if not store.supports_deletes:
55-
# TODO: confirm you get the expected error here
5655
pytest.skip("store does not support deletes")
5756
arr_new = Array.create(
5857
spath / "extant",

0 commit comments

Comments
 (0)