Skip to content

Commit d378242

Browse files
committed
resolve get before _getting in zipstore tests
1 parent 0b1c454 commit d378242

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/zarr/storage/zip.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,9 @@ def _get(
153153
byte_range: ByteRangeRequest | None = None,
154154
) -> Buffer | None:
155155
# docstring inherited
156+
# assume the key has already been made absolute
156157
try:
157-
with self._zf.open(self.resolve_key(key)) as f: # will raise KeyError
158+
with self._zf.open(key) as f: # will raise KeyError
158159
if byte_range is None:
159160
return prototype.buffer.from_bytes(f.read())
160161
start, length = byte_range

tests/v3/test_store/test_zip.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def store_kwargs(self, request) -> dict[str, str | bool]:
3030
return {"file_path": temp_path, "mode": "w", "path": ""}
3131

3232
async def get(self, store: ZipStore, key: str) -> Buffer:
33-
return store._get(key, prototype=default_buffer_prototype())
33+
return store._get(store.resolve_key(key), prototype=default_buffer_prototype())
3434

3535
async def set(self, store: ZipStore, key: str, value: Buffer) -> None:
3636
return store._set(store.resolve_key(key), value)

0 commit comments

Comments
 (0)