tests and types

Author: normanrz

src/zarr/core/array.py

@@ -3621,8 +3621,9 @@ async def create_array(
 
             raise ValueError(msg)
         filters_parsed, compressor_parsed = _parse_chunk_encoding_v2(
-            compressor=compressors, filters=filters, dtype=dtype_parsed
+            compressor=compressors, filters=filters, dtype=np.dtype(dtype)
         )
+        print(dtype_parsed)
         if dimension_names is not None:
             raise ValueError("Zarr v2 arrays do not support dimension names.")
         if order is None:
@@ -3788,6 +3789,7 @@ def _parse_chunk_encoding_v2(
             msg = f"For Zarr v2 arrays, the `compressor` must be a single codec. Got an iterable with type {type(compressor)} instead."
             raise TypeError(msg)
         _compressor = parse_compressor(compressor)
+
     if filters == "auto":
         _filters = default_filters
     else:

tests/test_array.py

@@ -976,7 +976,7 @@ async def test_create_array_v3_compressors(
         filters=(), compressors=compressors, dtype=np.dtype(dtype)
     )
     # TODO: find a better way to get the compressors from the array.
-    assert arr.codec_pipeline.bytes_bytes_codecs == bb_codecs_expected  # type: ignore[union-attr, attr-defined]
+    assert arr.codec_pipeline.bytes_bytes_codecs == bb_codecs_expected  # type: ignore[attr-defined]
 
 
 @pytest.mark.parametrize("store", ["memory"], indirect=True)
@@ -1028,7 +1028,7 @@ async def test_create_array_v3_filters(store: MemoryStore, filters: FiltersParam
         filters=filters, compressors=(), dtype=np.dtype(dtype)
     )
     # TODO: find a better way to get the filters from the array.
-    assert arr.codec_pipeline.array_array_codecs == aa_codecs_expected  # type: ignore[union-attr, attr-defined]
+    assert arr.codec_pipeline.array_array_codecs == aa_codecs_expected  # type: ignore[attr-defined]
 
 
 @pytest.mark.parametrize("store", ["memory"], indirect=True)