fix mypy

Author: brokkoli71

src/zarr/api/asynchronous.py

@@ -9,7 +9,6 @@
 import numpy.typing as npt
 from typing_extensions import deprecated
 
-from zarr import config
 from zarr.core.array import Array, AsyncArray, create_array, get_array_metadata
 from zarr.core.array_spec import ArrayConfig, ArrayConfigLike
 from zarr.core.buffer import NDArrayLike
@@ -25,6 +24,7 @@
     concurrent_map,
     parse_dtype,
 )
+from zarr.core.config import config
 from zarr.core.group import AsyncGroup, ConsolidatedMetadata, GroupMetadata
 from zarr.core.metadata import ArrayMetadataDict, ArrayV2Metadata, ArrayV3Metadata
 from zarr.core.metadata.v2 import _default_compressor, _default_filters

tests/conftest.py

@@ -78,7 +78,8 @@ async def store(request: pytest.FixtureRequest, tmpdir: LEGACY_PATH) -> Store:
 @pytest.fixture
 async def store2(request: pytest.FixtureRequest, tmpdir: LEGACY_PATH) -> Store:
     param = request.param
-    return await parse_store(param, str(tmpdir / "store2"))
+    store2_path = tmpdir.mkdir("store2")
+    return await parse_store(param, str(store2_path))
 
 
 @pytest.fixture(params=["local", "memory", "zip"])

tests/test_array.py

@@ -9,10 +9,10 @@
 import numcodecs
 import numpy as np
 import pytest
-from numpy.ma.testutils import assert_array_equal
 
 import zarr.api.asynchronous
 from zarr import Array, AsyncArray, Group
+from zarr.abc.store import Store
 from zarr.codecs import (
     BytesCodec,
     GzipCodec,
@@ -1265,14 +1265,16 @@ async def test_scalar_array() -> None:
     assert arr.shape == ()
 
 
-@pytest.mark.parametrize("store", ["memory", "local"], indirect=True)
-@pytest.mark.parametrize("store2", ["memory", "local"], indirect=True)
+@pytest.mark.parametrize("store", ["local", "memory", "zip"], indirect=["store"])
+@pytest.mark.parametrize("store2", ["local", "memory", "zip"], indirect=["store2"])
 @pytest.mark.parametrize("src_chunks", [(1, 2), (5, 5), (5, 10)])
 @pytest.mark.parametrize("new_chunks", [(1, 2), (5, 5), (5, 10)])
-async def test_creation_from_other_zarr(store, store2, src_chunks, new_chunks):
+async def test_creation_from_other_zarr(
+    store: Store, store2: Store, src_chunks: tuple[int, int], new_chunks: tuple[int, int]
+) -> None:
     src_fill_value = 2
     src_dtype = np.dtype("uint8")
-    src_attributes = {}
+    src_attributes = None
 
     src = zarr.create(
         (10, 10),
@@ -1297,7 +1299,7 @@ async def test_creation_from_other_zarr(store, store2, src_chunks, new_chunks):
         attributes=new_attributes,
     )
 
-    assert_array_equal(result2[:], src[:])
+    np.testing.assert_array_equal(result2[:], src[:])
     assert result2.fill_value == new_fill_value
     assert result2.dtype == new_dtype
     assert result2.attrs == new_attributes