add timedelta and deltatime to the test_default_fill_value

Author: rvestrum3vg

docs/user-guide/arrays.rst

@@ -625,6 +625,7 @@ Datetime and Timedelta arrays
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 NumPy’s datetime64 (‘M8’) and timedelta64 (‘m8’) dtypes are supported for Zarr arrays, as long as the units are specified. E.g.:
 
+.. code-block:: python
    >>> data = np.array(['2007-07-13', '2006-01-13', '2010-08-13'], dtype='M8[D]')
    >>> z = zarr.create_array(store='data/example-datetime.zarr', shape=data.shape, dtype=data.dtype)
    >>> z[:] = data

src/zarr/core/metadata/v3.py

@@ -659,24 +659,24 @@ class DataType(Enum):
     float64 = "float64"
     complex64 = "complex64"
     complex128 = "complex128"
-    datetime64ns = ("datetime[ns]",)
-    datetime64ms = ("datetime[ms]",)
-    datetime64s = ("datetime[s]",)
-    datetime64m = ("datetime[m]",)
-    datetime64h = ("datetime[h]",)
-    datetime64D = ("datetime[D]",)
-    datetime64W = ("datetime[W]",)
-    datetime64M = ("datetime[M]",)
-    datetime64Y = ("datetime[Y]",)
-    timedelta64ns = ("deltatime[ns]",)
-    timedelta64ms = ("deltatime[ms]",)
-    timedelta64s = ("deltatime[s]",)
-    timedelta64m = ("deltatime[m]",)
-    timedelta64h = ("deltatime[h]",)
-    timedelta64D = ("deltatime[D]",)
-    timedelta64W = ("deltatime[W]",)
-    timedelta64M = ("deltatime[M]",)
-    timedelta64Y = ("deltatime[Y]",)
+    datetime64ns = "datetime64ns"
+    datetime64ms = "datetime64ms"
+    datetime64s = "datetime64s"
+    datetime64m = "datetime64m"
+    datetime64h = "datetime64h"
+    datetime64D = "datetime64D"
+    datetime64W = "datetime64W"
+    datetime64M = "datetime64M"
+    datetime64Y = "datetime64Y"
+    timedelta64ns = "timedelta64ns"
+    timedelta64ms = "timedelta64ms"
+    timedelta64s = "timedelta64s"
+    timedelta64m = "timedelta64m"
+    timedelta64h = "timedelta64h"
+    timedelta64D = "timedelta64D"
+    timedelta64W = "timedelta64W"
+    timedelta64M = "timedelta64M"
+    timedelta64Y = "timedelta64Y"
     string = "string"
     bytes = "bytes"
 

tests/test_metadata/test_v3.py

@@ -56,7 +56,37 @@
 complex_dtypes = ("complex64", "complex128")
 vlen_dtypes = ("string", "bytes")
 
-dtypes = (*bool_dtypes, *int_dtypes, *float_dtypes, *complex_dtypes, *vlen_dtypes)
+datetime_dtypes = (
+    "datetime64ns",
+    "datetime64ms",
+    "datetime64s",
+    "datetime64m",
+    "datetime64h",
+    "datetime64D",
+    "datetime64W",
+    "datetime64M",
+    "datetime64Y",
+)
+deltatime_dtypes = (
+    "timedelta64ns",
+    "timedelta64ms",
+    "timedelta64s",
+    "timedelta64m",
+    "timedelta64h",
+    "timedelta64D",
+    "timedelta64W",
+    "timedelta64M",
+    "timedelta64Y",
+)
+dtypes = (
+    *bool_dtypes,
+    *int_dtypes,
+    *float_dtypes,
+    *complex_dtypes,
+    *vlen_dtypes,
+    *datetime_dtypes,
+    *deltatime_dtypes,
+)
 
 
 @pytest.mark.parametrize("data", [None, 1, 2, 4, 5, "3"])
@@ -119,6 +149,8 @@ def test_default_fill_value(dtype_str: str) -> None:
         assert fill_value == ""
     elif dtype == DataType.bytes:
         assert fill_value == b""
+    elif np.dtype(dtype.to_numpy()).kind in "Mm":
+        assert np.isnat(fill_value.view())
     else:
         assert fill_value == dtype.to_numpy().type(0)