Provide more informative error message

Author: maxrjones

src/zarr/storage/_fsspec.py

@@ -232,7 +232,7 @@ async def get(
                     await self.fs._cat_file(path, start=-byte_range.suffix, end=None)
                 )
             else:
-                raise ValueError("Invalid format for ByteRequest")
+                raise ValueError(f"Unexpected byte_range, got {byte_range}.")
         except self.allowed_exceptions:
             return None
         except OSError as e:
@@ -303,7 +303,7 @@ async def get_partial_values(
                     starts.append(-byte_range.suffix)
                     stops.append(None)
                 else:
-                    raise ValueError("Invalid format for ByteRequest")
+                    raise ValueError(f"Unexpected byte_range, got {byte_range}.")
         else:
             return []
         # TODO: expectations for exceptions or missing keys?

src/zarr/storage/_local.py

@@ -37,7 +37,7 @@ def _get(path: Path, prototype: BufferPrototype, byte_range: ByteRequest | None)
         elif isinstance(byte_range, SuffixByteRequest):
             f.seek(max(0, size - byte_range.suffix))
         else:
-            raise TypeError("Invalid format for ByteRequest")
+            raise TypeError(f"Unexpected byte_range, got {byte_range}.")
         return prototype.buffer.from_bytes(f.read())
 
 

src/zarr/storage/_utils.py

@@ -63,4 +63,6 @@ def _normalize_byte_range_index(data: Buffer, byte_range: ByteRequest | None) ->
     elif isinstance(byte_range, SuffixByteRequest):
         start = len(data) - byte_range.suffix
         stop = len(data) + 1
+    else:
+        raise ValueError(f"Unexpected byte_range, got {byte_range}.")
     return (start, stop)

src/zarr/storage/_zip.py

@@ -160,7 +160,7 @@ def _get(
                 elif isinstance(byte_range, SuffixByteRequest):
                     f.seek(max(0, size - byte_range.suffix))
                 else:
-                    raise TypeError("Invalid format for ByteRequest")
+                    raise TypeError(f"Unexpected byte_range, got {byte_range}.")
                 return prototype.buffer.from_bytes(f.read())
         except KeyError:
             return None