Fix N5Store.__contains__ (#550)

* Fix N5Store.__contains__

* added release note

Co-authored-by: Alistair Miles <[email protected]>

Author: gsakkis

docs/release.rst

@@ -1,6 +1,14 @@
 Release notes
 =============
 
+
+Next release
+------------
+
+* Fix minor bug in `N5Store`. 
+  By :user:`gsakkis`, :issue:`550`.
+
+
 .. _release_2.4.0:
 
 2.4.0

zarr/n5.py

@@ -175,9 +175,9 @@ def __contains__(self, key):
             # array if attributes contain 'dimensions'
             return 'dimensions' in self._load_n5_attrs(key)
 
-        elif key.endswith(zarr_attrs_key):  # pragma: no cover
+        elif key.endswith(zarr_attrs_key):
 
-            key = key.replace(zarr_array_meta_key, n5_attrs_key)
+            key = key.replace(zarr_attrs_key, n5_attrs_key)
             return self._contains_attrs(key)
 
         elif is_chunk_key(key):

zarr/tests/test_core.py

@@ -1255,9 +1255,12 @@ def test_endian(self):
     def test_attributes(self):
         a = self.create_array(shape=10, chunks=10, dtype='i8')
         a.attrs['foo'] = 'bar'
+        assert a.attrs.key in a.store
         attrs = json_loads(a.store[a.attrs.key])
         assert 'foo' in attrs and attrs['foo'] == 'bar'
+
         a.attrs['bar'] = 'foo'
+        assert a.attrs.key in a.store
         attrs = json_loads(a.store[a.attrs.key])
         assert 'foo' in attrs and attrs['foo'] == 'bar'
         assert 'bar' in attrs and attrs['bar'] == 'foo'