use Posixpath instead of Path in tests; avoid redundant cast

Author: d-v-b

tests/conftest.py

@@ -2,15 +2,14 @@
 
 import pathlib
 from dataclasses import dataclass, field
-from typing import TYPE_CHECKING, cast
+from typing import TYPE_CHECKING
 
 import numpy as np
 import numpy.typing as npt
 import pytest
 from hypothesis import HealthCheck, Verbosity, settings
 
 from zarr import AsyncGroup, config
-from zarr.abc.codec import Codec
 from zarr.abc.store import Store
 from zarr.codecs.sharding import ShardingCodec, ShardingCodecIndexLocation
 from zarr.core.array import (
@@ -32,6 +31,7 @@
 
     from _pytest.compat import LEGACY_PATH
 
+    from zarr.abc.codec import Codec
     from zarr.core.array import CompressorsLike, FiltersLike, SerializerLike, ShardsLike
     from zarr.core.chunk_key_encodings import ChunkKeyEncoding, ChunkKeyEncodingLike
     from zarr.core.common import ChunkCoords, MemoryOrder, ShapeLike, ZarrFormat
@@ -273,7 +273,7 @@ def create_array_metadata(
             dtype=dtype_parsed,
         )
 
-        sub_codecs = cast(tuple[Codec, ...], (*array_array, array_bytes, *bytes_bytes))
+        sub_codecs = (*array_array, array_bytes, *bytes_bytes)
         codecs_out: tuple[Codec, ...]
         if shard_shape_parsed is not None:
             index_location = None

tests/test_group.py

@@ -4,7 +4,7 @@
 import operator
 import pickle
 import warnings
-from pathlib import Path
+from pathlib import PosixPath
 from typing import TYPE_CHECKING, Any, Literal
 
 import numpy as np
@@ -1457,7 +1457,7 @@ async def test_create_nodes(store: Store, zarr_format: ZarrFormat) -> None:
     }
     spath = await make_store_path(store, path="foo")
     observed_nodes = {
-        str(Path(a.name).relative_to("/" + path)): a
+        str(PosixPath(a.name).relative_to("/" + path)): a
         async for a in create_nodes(store_path=spath, nodes=expected_meta)
     }
     assert expected_meta == {k: v.metadata for k, v in observed_nodes.items()}
@@ -1480,7 +1480,7 @@ async def test_create_hierarchy(store: Store, zarr_format: ZarrFormat) -> None:
     expected_meta = hierarchy_spec | {"group/subgroup": GroupMetadata(zarr_format=zarr_format)}
     spath = await make_store_path(store, path="foo")
     observed_nodes = {
-        str(Path(a.name).relative_to("/" + path)): a
+        str(PosixPath(a.name).relative_to("/" + path)): a
         async for a in create_hierarchy(store_path=spath, nodes=expected_meta)
     }
     assert expected_meta == {k: v.metadata for k, v in observed_nodes.items()}