Revert "fix mypy in tests"

This reverts commit 34bf260.

Author: brokkoli71

tests/test_api.py

@@ -235,7 +235,7 @@ def test_open_with_mode_r(tmp_path: pathlib.Path) -> None:
     z2 = zarr.open(store=tmp_path, mode="r")
     assert isinstance(z2, Array)
     assert z2.fill_value == 1
-    assert np.array(z2[:] == 1).all()
+    assert (z2[:] == 1).all()
     with pytest.raises(ValueError):
         z2[:] = 3
 
@@ -247,7 +247,7 @@ def test_open_with_mode_r_plus(tmp_path: pathlib.Path) -> None:
     zarr.ones(store=tmp_path, shape=(3, 3))
     z2 = zarr.open(store=tmp_path, mode="r+")
     assert isinstance(z2, Array)
-    assert np.array(z2[:] == 1).all()
+    assert (z2[:] == 1).all()
     z2[:] = 3
 
 
@@ -263,7 +263,7 @@ async def test_open_with_mode_a(tmp_path: pathlib.Path) -> None:
     arr[...] = 1
     z2 = zarr.open(store=tmp_path, mode="a")
     assert isinstance(z2, Array)
-    assert np.array(z2[:] == 1).all()
+    assert (z2[:] == 1).all()
     z2[:] = 3
 
 
@@ -1119,5 +1119,5 @@ def test_open_array_with_mode_r_plus(store: Store) -> None:
     zarr.ones(store=store, shape=(3, 3))
     z2 = zarr.open_array(store=store, mode="r+")
     assert isinstance(z2, Array)
-    assert np.array(z2[:] == 1).all()
+    assert (z2[:] == 1).all()
     z2[:] = 3

tests/test_array.py

@@ -649,15 +649,15 @@ def test_resize_1d(store: MemoryStore, zarr_format: ZarrFormat) -> None:
     a = np.arange(105, dtype="i4")
     z[:] = a
     assert (105,) == z.shape
-    assert (105,) == z[:].shape # type: ignore
+    assert (105,) == z[:].shape
     assert np.dtype("i4") == z.dtype
-    assert np.dtype("i4") == z[:].dtype # type: ignore
+    assert np.dtype("i4") == z[:].dtype
     assert (10,) == z.chunks
     np.testing.assert_array_equal(a, z[:])
 
     z.resize(205)
     assert (205,) == z.shape
-    assert (205,) == z[:].shape # type: ignore
+    assert (205,) == z[:].shape
     assert np.dtype("i4") == z.dtype
     assert np.dtype("i4") == z[:].dtype
     assert (10,) == z.chunks

tests/test_buffer.py

@@ -62,8 +62,10 @@ async def test_async_array_prototype() -> None:
         prototype=my_prototype,
     )
     got = await a.getitem(selection=(slice(0, 9), slice(0, 9)), prototype=my_prototype)
-    assert isinstance(got, TestNDArrayLike)
-    assert np.array_equal(expect, got)
+    # ignoring a mypy error here that TestNDArrayLike doesn't meet the NDArrayLike protocol
+    # The test passes, so it clearly does.
+    assert isinstance(got, TestNDArrayLike)  # type: ignore[unreachable]
+    assert np.array_equal(expect, got)  # type: ignore[unreachable]
 
 
 @gpu_test
@@ -113,8 +115,10 @@ async def test_codecs_use_of_prototype() -> None:
         prototype=my_prototype,
     )
     got = await a.getitem(selection=(slice(0, 10), slice(0, 10)), prototype=my_prototype)
-    assert isinstance(got, TestNDArrayLike)
-    assert np.array_equal(expect, got)
+    # ignoring a mypy error here that TestNDArrayLike doesn't meet the NDArrayLike protocol
+    # The test passes, so it clearly does.
+    assert isinstance(got, TestNDArrayLike)  # type: ignore[unreachable]
+    assert np.array_equal(expect, got)  # type: ignore[unreachable]
 
 
 @gpu_test