Improve test coverage

Author: maxrjones

src/zarr/storage/_common.py

@@ -321,9 +321,9 @@ async def make_store_path(
             if not isinstance(store_like, FSMap):
                 raise (TypeError(f"Unsupported type for store_like: '{type(store_like).__name__}'"))
             if path:
-                raise TypeError("'path' was provided but is not used for FSMap store_like objects")
+                raise ValueError("'path' was provided but is not used for FSMap store_like objects")
             if storage_options:
-                raise TypeError(
+                raise ValueError(
                     "'storage_options was provided but is not used for FSMap store_like objects"
                 )
             store = FsspecStore.from_mapper(store_like, read_only=_read_only)

tests/test_store/test_fsspec.py

@@ -118,6 +118,22 @@ def test_open_s3map() -> None:
     z2[:] = 3
 
 
+def test_open_s3map_raises() -> None:
+    with pytest.raises(TypeError, match="Unsupported type for store_like:.*"):
+        zarr.open(store=0, mode="w", shape=(3, 3))
+    s3_filesystem = s3fs.S3FileSystem(asynchronous=True, endpoint_url=endpoint_url, anon=False)
+    mapper = s3_filesystem.get_mapper(f"s3://{test_bucket_name}/map/foo/")
+    with pytest.raises(
+        ValueError, match="'path' was provided but is not used for FSMap store_like objects"
+    ):
+        zarr.open(store=mapper, mode="w", shape=(3, 3), path="foo")
+    with pytest.raises(
+        ValueError,
+        match="'storage_options was provided but is not used for FSMap store_like objects",
+    ):
+        zarr.open(store=mapper, mode="w", shape=(3, 3), storage_options={"anon": True})
+
+
 class TestFsspecStoreS3(StoreTests[FsspecStore, cpu.Buffer]):
     store_cls = FsspecStore
     buffer_cls = cpu.Buffer