Apply assorted ruff/Pylint rules (PLR) (#2371)

* Apply ruff/Pylint rule PLR1711

PLR1711 Useless `return` statement at end of function

* Apply ruff/Pylint rule PLR2044

PLR2044 Line with empty comment

* Apply ruff/Pylint rule PLR6104

PLR6104 Use `+=`, `*=`, `/=` to perform an augmented assignment directly

---------

Co-authored-by: Joe Hamman <[email protected]>

Author: DimitriPapadopoulos

src/zarr/abc/store.py

@@ -284,7 +284,6 @@ async def _set_many(self, values: Iterable[tuple[str, Buffer]]) -> None:
         Insert multiple (key, value) pairs into storage.
         """
         await gather(*starmap(self.set, values))
-        return
 
     @property
     @abstractmethod

src/zarr/codecs/sharding.py

@@ -252,7 +252,7 @@ def create_empty(
     def __setitem__(self, chunk_coords: ChunkCoords, value: Buffer) -> None:
         chunk_start = len(self.buf)
         chunk_length = len(value)
-        self.buf = self.buf + value
+        self.buf += value
         self.index.set_chunk_slice(chunk_coords, slice(chunk_start, chunk_start + chunk_length))
 
     def __delitem__(self, chunk_coords: ChunkCoords) -> None:

src/zarr/core/indexing.py

@@ -675,7 +675,7 @@ def check(a: npt.NDArray[Any]) -> Order:
 def wraparound_indices(x: npt.NDArray[Any], dim_len: int) -> None:
     loc_neg = x < 0
     if np.any(loc_neg):
-        x[loc_neg] = x[loc_neg] + dim_len
+        x[loc_neg] += dim_len
 
 
 def boundscheck_indices(x: npt.NDArray[Any], dim_len: int) -> None:
@@ -1000,8 +1000,8 @@ def __init__(
                 if stop < 0:
                     stop = dim_numchunks + stop
 
-                start = start * dim_chunk_size
-                stop = stop * dim_chunk_size
+                start *= dim_chunk_size
+                stop *= dim_chunk_size
                 slice_ = slice(start, stop)
 
             else:

tests/test_codecs/test_sharding.py

@@ -229,7 +229,7 @@ def test_sharding_partial_overwrite(
     read_data = a[0:10, 0:10, 0:10]
     assert np.array_equal(data, read_data)
 
-    data = data + 10
+    data += 10
     a[:10, :10, :10] = data
     read_data = a[0:10, 0:10, 0:10]
     assert np.array_equal(data, read_data)

tests/test_sync.py

@@ -147,7 +147,7 @@ def test_open_positional_args_deprecate():
         zarr.open(store, "w", shape=(1,))
 
 
-@pytest.mark.parametrize("workers", [None, 1, 2])  #
+@pytest.mark.parametrize("workers", [None, 1, 2])
 def test_get_executor(clean_state, workers) -> None:
     with zarr.config.set({"threading.max_workers": workers}):
         e = _get_executor()