Skip to content

Commit f2c827d

Browse files
committed
Fix constructing prototype from get
1 parent cca70d7 commit f2c827d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/zarr/storage/object_store.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,20 +39,20 @@ async def get(
3939
) -> Buffer:
4040
if byte_range is None:
4141
resp = await obs.get_async(self.store, key)
42-
return prototype.buffer.from_buffer(memoryview(await resp.bytes_async())) # type: ignore not assignable to buffer
42+
return prototype.buffer.from_bytes(await resp.bytes_async())
4343

4444
start, end = byte_range
4545
if start is not None and end is not None:
4646
resp = await obs.get_range_async(self.store, key, start=start, end=end)
47-
return prototype.buffer.from_buffer(memoryview(await resp.bytes_async())) # type: ignore not assignable to buffer
47+
return prototype.buffer.from_bytes(memoryview(resp))
4848
elif start is not None:
4949
if start >= 0:
5050
# Offset request
5151
resp = await obs.get_async(self.store, key, options={"range": {"offset": start}})
5252
else:
5353
resp = await obs.get_async(self.store, key, options={"range": {"suffix": start}})
5454

55-
return prototype.buffer.from_buffer(memoryview(await resp.bytes_async())) # type: ignore not assignable to buffer
55+
return prototype.buffer.from_bytes(await resp.bytes_async())
5656
else:
5757
raise ValueError(f"Unexpected input to `get`: {start=}, {end=}")
5858

@@ -265,7 +265,7 @@ async def _get_partial_values(
265265
other_requests.append(
266266
{"original_request_index": idx, "path": path, "range": {"suffix": abs(start)}}
267267
)
268-
elif end is None and start > 0:
268+
elif end is None and start >= 0:
269269
# Offset request to the end
270270
other_requests.append(
271271
{"original_request_index": idx, "path": path, "range": {"offset": start}}

0 commit comments

Comments
 (0)