increase test coverage

Author: alimanfoo

zarr/meta.py

@@ -83,14 +83,10 @@ def decode_group_metadata(b):
     zarr_format = meta.get('zarr_format', None)
     if zarr_format != ZARR_FORMAT:
         raise MetadataError('unsupported zarr format: %s' % zarr_format)
-    try:
-        meta = dict(
-            zarr_format=meta['zarr_format'],
-        )
-    except Exception as e:
-        raise MetadataError('error decoding metadata: %s' % e)
-    else:
-        return meta
+    meta = dict(
+        zarr_format=ZARR_FORMAT,
+    )
+    return meta
 
 
 def encode_group_metadata(meta=None):

zarr/tests/test_attrs.py

@@ -15,22 +15,20 @@
 class TestAttributes(unittest.TestCase):
 
     def init_attributes(self, store, readonly=False):
-        key = 'attrs'
-        store[key] = json.dumps(dict()).encode('ascii')
-        return Attributes(store, key=key, readonly=readonly)
+        return Attributes(store, key='attrs', readonly=readonly)
 
     def test_storage(self):
 
         store = dict()
-        a = self.init_attributes(store)
-        assert 'attrs' in store
-        assert isinstance(store['attrs'], binary_type)
-        d = json.loads(text_type(store['attrs'], 'ascii'))
-        eq(dict(), d)
+        a = Attributes(store=store, key='attrs')
+        assert 'foo' not in a
+        assert 'bar' not in a
+        eq(dict(), a.asdict())
 
         a['foo'] = 'bar'
         a['baz'] = 42
-
+        assert 'attrs' in store
+        assert isinstance(store['attrs'], binary_type)
         d = json.loads(text_type(store['attrs'], 'ascii'))
         eq(dict(foo='bar', baz=42), d)
 

zarr/tests/test_meta.py

@@ -9,7 +9,7 @@
 
 from zarr.compat import PY2
 from zarr.meta import decode_array_metadata, encode_dtype, decode_dtype, \
-    ZARR_FORMAT
+    ZARR_FORMAT, decode_group_metadata
 from zarr.errors import MetadataError
 
 
@@ -101,3 +101,24 @@ def test_encode_decode_dtype():
         o = json.loads(s)
         d = decode_dtype(o)
         eq(np.dtype(dt), d)
+
+
+def test_decode_group():
+
+    # typical
+    b = '''{
+        "zarr_format": %s
+    }''' % ZARR_FORMAT
+    if not PY2:
+        b = b.encode('ascii')
+    meta = decode_group_metadata(b)
+    eq(ZARR_FORMAT, meta['zarr_format'])
+
+    # unsupported format
+    b = '''{
+        "zarr_format": %s
+    }''' % (ZARR_FORMAT - 1)
+    if not PY2:
+        b = b.encode('ascii')
+    with assert_raises(MetadataError):
+        decode_group_metadata(b)