Skip to content

Commit f6e6c8c

Browse files
committed
fixes s3 fixture for s3 test complex
1 parent 847e78a commit f6e6c8c

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

zarr/storage.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1113,9 +1113,7 @@ def rmdir(self, path=None):
11131113
raise ReadOnlyError()
11141114
store_path = self.dir_path(path)
11151115
if self.fs.isdir(store_path):
1116-
# sometimes doesn't delete on first try with S3
1117-
while self.fs.exists(store_path):
1118-
self.fs.rm(store_path, recursive=True)
1116+
self.fs.rm(store_path, recursive=True)
11191117

11201118
def getsize(self, path=None):
11211119
store_path = self.dir_path(path)

zarr/tests/test_storage.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1030,8 +1030,11 @@ def s3(request):
10301030
pass
10311031
timeout -= 0.1 # pragma: no cover
10321032
time.sleep(0.1) # pragma: no cover
1033-
s3so = dict(client_kwargs={'endpoint_url': endpoint_uri})
1033+
s3so = dict(client_kwargs={'endpoint_url': endpoint_uri},
1034+
use_listings_cache=False)
10341035
s3 = s3fs.S3FileSystem(anon=False, **s3so)
1036+
if s3.exists("test"):
1037+
s3.rm("test", recursive=True)
10351038
s3.mkdir("test")
10361039
request.cls.s3so = s3so
10371040
yield

0 commit comments

Comments
 (0)