Skip to content

remove compressor kwarg from create_array #2818

@d-v-b

Description

@d-v-b

In #2709 we ended up with a new keyword argument (compressor) in Group.create_array, unfortunately this creates confusion given that Group.create_array already takes a compressors kwarg, and create_array (the function Group.create_array ultimately invokes) only takes compressors.

New functions like create_array should be kept clear of confusing / redundant keyword arguments, and we should also ensure that Group.<func> has nearly the same signature as <func>, so for both these reasons I think we should hastily remove the compressor kwarg from Group.create_array, and ensure that the issue solved by #2709 can be solved via the compressors kwarg.

cc @martindurant

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions