-
-
Notifications
You must be signed in to change notification settings - Fork 367
Open
Description
In #2709 we ended up with a new keyword argument (compressor) in Group.create_array, unfortunately this creates confusion given that Group.create_array already takes a compressors kwarg, and create_array (the function Group.create_array ultimately invokes) only takes compressors.
New functions like create_array should be kept clear of confusing / redundant keyword arguments, and we should also ensure that Group.<func> has nearly the same signature as <func>, so for both these reasons I think we should hastily remove the compressor kwarg from Group.create_array, and ensure that the issue solved by #2709 can be solved via the compressors kwarg.
Metadata
Metadata
Assignees
Labels
No labels