From 56ef024da74ea091a76dba848460bd7d48bbfc13 Mon Sep 17 00:00:00 2001 From: Max Jones <14077947+maxrjones@users.noreply.github.com> Date: Fri, 13 Dec 2024 21:16:59 -0500 Subject: [PATCH 1/2] Raise an exeption for previously set key --- src/zarr/testing/store.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/zarr/testing/store.py b/src/zarr/testing/store.py index 53dee012bf..9e6b9340fd 100644 --- a/src/zarr/testing/store.py +++ b/src/zarr/testing/store.py @@ -319,8 +319,9 @@ async def test_set_if_not_exists(self, store: S) -> None: data_buf = self.buffer_cls.from_bytes(b"0000") await self.set(store, key, data_buf) - new = self.buffer_cls.from_bytes(b"1111") - await store.set_if_not_exists("k", new) # no error + with pytest.raises(Exception): + new = self.buffer_cls.from_bytes(b"1111") + await store.set_if_not_exists("k", new) result = await store.get(key, default_buffer_prototype()) assert result == data_buf From ae770eb006f12601adb09f53c8184df44cc28bee Mon Sep 17 00:00:00 2001 From: Max Jones <14077947+maxrjones@users.noreply.github.com> Date: Sat, 14 Dec 2024 15:39:06 -0500 Subject: [PATCH 2/2] Update src/zarr/testing/store.py Co-authored-by: Davis Bennett --- src/zarr/testing/store.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/zarr/testing/store.py b/src/zarr/testing/store.py index 9e6b9340fd..7b19d39552 100644 --- a/src/zarr/testing/store.py +++ b/src/zarr/testing/store.py @@ -321,7 +321,7 @@ async def test_set_if_not_exists(self, store: S) -> None: with pytest.raises(Exception): new = self.buffer_cls.from_bytes(b"1111") - await store.set_if_not_exists("k", new) + await store.set_if_not_exists(key, new) result = await store.get(key, default_buffer_prototype()) assert result == data_buf