Skip to content

Prevent lines containing ... being excluded from coverage #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

Prevent lines containing ... being excluded from coverage #3298

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcddaf0
prevent matching ... in longer lines
K-Meech Jul 25, 2025
9dfbae2
Merge branch 'main' into km/coverage-exclude
d-v-b Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ gpu = [
]
# Development extras
test = [
"coverage",
"coverage>=7.10",
# Pin possibly due to https://github.com/pytest-dev/pytest-cov/issues/693
"pytest<8.4",
"pytest-asyncio",
Expand Down Expand Up @@ -128,11 +128,8 @@ dev = [
]

[tool.coverage.report]
exclude_lines = [
"pragma: no cover",
"if TYPE_CHECKING:",
"pragma: ${PY_MAJOR_VERSION} no cover",
Copy link
Contributor

@d-v-b d-v-b Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the pragma: no cover directive handled automatically with the new version of coverage?

Copy link
Contributor Author

@K-Meech K-Meech Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - it's listed in the default exclusions. I also checked locally, and lines tagged with # pragma: no cover seemed to be excluded correctly.

'.*\.\.\.' # Ignore "..." lines
exclude_also = [
'if TYPE_CHECKING:',
]

[tool.coverage.run]
Expand Down
Loading