chore/add missing tests #3353
Open
chore/add missing tests #3353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
…n into chore/add-missing-tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3353 +/- ##
==========================================
+ Coverage 94.55% 94.66% +0.10%
==========================================
Files 79 79
Lines 9448 9445 -3
==========================================
+ Hits 8934 8941 +7
+ Misses 514 504 -10
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes some unreachable lines of code from test coverage, and adds tests for a few missing routines in
zarr.api.asynchronous.I put those missing tests in a new directory to ensure that the tests are found in a location that matches the layout of the source code (unlike our current api tests). Eventually we should move all of the tests in
tests/test_api.pytotests/test_api/test_asynchronous.pyortests/test_api/test_synchronous.py.I did not add a test for
api.asynchronous.open_likebecause it's broken. see #3352 .