Pass read_only into LocalStore.open() #3432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `read_only` is not passed in `open()`, which means the default value of `read_only=False` is confusingly used instead. This mostly just surprisng, but also has minor performance implications because `read_only=False` means Zarr attempts to create directories on this line (which is a no-op because `exist_ok=True`): https://github.com/zarr-developers/zarr-python/blob/e738e2fb88dbead26a853d9982ff46eab64f313f/src/zarr/storage/_local.py#L167-L169
github-actions
bot
added
the
needs release notes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 79 79
Lines 9491 9491
=======================================
Hits 9009 9009
Misses 482 482
🚀 New features to boost your workflow:
|
|
is it feasible to add a test? |
I don't think so, unfortunately, short of excessive mocking. This is just an internal cleanup, to avoid code smell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
read_onlyis not passed inopen(), which means the default value ofread_only=Falseis confusingly used instead.This mostly just surprisng, but also has minor performance implications because
read_only=Falsemeans Zarr attempts to create directories on this line (which is a no-op becauseexist_ok=True):zarr-python/src/zarr/storage/_local.py
Lines 167 to 169 in e738e2f
TODO: