Skip to content

chore(crc32c): replace crc32c with google-crc32c dependency #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore(crc32c): replace crc32c with google-crc32c dependency #3515

wants to merge 5 commits into from
+32 −8

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Oct 9, 2025 •
edited
Loading

This PR replaces the crc32c dependency with the google-crc32c package. The behavior of the codec is not expected to have changed.

partially fixes #3510
xref: zarr-developers/numcodecs#792

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Oct 9, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.86%. Comparing base (6811c94) to head (863db4b).

Files with missing lines Patch % Lines
src/zarr/codecs/crc32c_.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3515   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          85       85           
  Lines       10111    10111           
=======================================
  Hits         6255     6255           
  Misses       3856     3856
Files with missing lines Coverage Δ
src/zarr/codecs/crc32c_.py 43.75% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhamman jhamman requested review from d-v-b and normanrz October 11, 2025 04:54
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@normanrz normanrz normanrz approved these changes

@d-v-b d-v-b Awaiting requested review from d-v-b

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop numcodecs[crc32c] as dependency due to use of LGPL license

2 participants

@jhamman @normanrz