Skip to content

Commit 1b69120

Browse files
authored
(fix): pin maturin version and always run CI (#65)
* (fix): twine version * (chore): now try without * (fix): try checking twine version * (fix): fowngrade to python 3.12 (hopefully can check against different interpreters * (fix): pin maturin * (chore): put python version back * (chore): pin maturin in the right place * (fix): run ci build + build-sdist on PRs
1 parent 4ec5dc2 commit 1b69120

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/cd.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ jobs:
1616
name: build on ${{ matrix.os }} (${{ matrix.target }}${{ matrix.os == 'linux' && format(' - {0}', matrix.manylinux == 'auto' && 'manylinux' || matrix.manylinux) || '' }})
1717
# only run on push to tags, main branch, or explicit full build
1818
# keep condition in sync with `build-sdist` job
19-
if: github.ref_type == 'tag' || github.ref == 'refs/heads/main' || contains(github.event.pull_request.labels.*.name, 'Full Build')
2019
strategy:
2120
fail-fast: false
2221
matrix:
@@ -50,6 +49,8 @@ jobs:
5049
args: --release --out dist --interpreter '3.11 3.12 3.13'
5150
rust-toolchain: stable
5251
docker-options: -e CI
52+
# https://github.com/PyO3/maturin/issues/2336#issuecomment-2507418846
53+
maturin-version: 1.7.4
5354
before-script-linux: |
5455
# If we're running on rhel centos, install needed packages.
5556
if command -v yum &> /dev/null; then
@@ -65,7 +66,6 @@ jobs:
6566
build-sdist:
6667
name: build sdist
6768
# keep condition in sync with `build` job
68-
if: github.ref_type == 'tag' || github.ref == 'refs/heads/main' || contains(github.event.pull_request.labels.*.name, 'Full Build')
6969
runs-on: ubuntu-latest
7070
steps:
7171
- uses: actions/checkout@v4
@@ -74,6 +74,8 @@ jobs:
7474
python-version: '3.13'
7575
- uses: PyO3/maturin-action@v1
7676
with:
77+
# https://github.com/PyO3/maturin/issues/2336#issuecomment-2507418846
78+
maturin-version: 1.7.4
7779
command: sdist
7880
args: --out dist
7981
rust-toolchain: stable

0 commit comments

Comments
 (0)