linter fixes

Author: simonfranzen

README.md

@@ -99,6 +99,8 @@ Annotates Rails/ActiveRecord Models, routes, fixtures, and others based on the d
 ### 9. Abilities with CanCanCan
 [CanCanCan](https://github.com/CanCanCommunity/cancancan) is an authorization library for Ruby and Ruby on Rails which restricts what resources a given user is allowed to access. We combine this gem with a `role` field defined on user model.
 
+Start defining your abilities under `app/models/aility.rb`.
+
 ### 10. Rails Admin
 To access the data of your application you can access the [rails_admin](https://github.com/sferik/rails_admin) dashboard under route `/admin`. It's currently only allowed for users with role superadmin.
 

app/controllers/application_controller.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Base controlller for application
 class ApplicationController < ActionController::Base
   force_ssl if: :ssl_configured?
 

app/controllers/pages_controller.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
+# A controller to handle static pages served from backend
 class PagesController < ApplicationController
   def blank
-    head 200, content_type: "text/html"
+    head 200, content_type: 'text/html'
   end
-end
+end

app/models/ability.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+# Defines abilities for user
+# rubocop:disable Style/GuardClause
 class Ability
   include CanCan::Ability
 
@@ -6,16 +10,17 @@ def initialize(user)
 
     alias_action :create, :read, :update, :destroy, to: :crud
 
-    unless user.new_record?
-      if user.superadmin?
-        can :access, :rails_admin         # grant access to rails_admin
-        can :manage, :all                 # admins can manage all objects
-      elsif user.admin?
-        # can :crud,    Survey::QuestionAnswer              # user can crud all question answers
-      end
+    return if user.new_record?
+
+    if user.superadmin?
+      can :access, :rails_admin         # grant access to rails_admin
+      can :manage, :all                 # admins can manage all objects
+      # elsif user.admin?
+      # can :crud,    Survey::QuestionAnswer              # user can crud all question answers
     end
 
     # See the wiki for details:
     # https://github.com/CanCanCommunity/cancancan/wiki/Defining-Abilities
   end
 end
+# rubocop:enable Style/GuardClause

app/models/user.rb

@@ -2,7 +2,6 @@
 
 # User model to access application
 class User < ApplicationRecord
-
   # Include default devise modules. Others available are:
   # :confirmable, :timeoutable, :trackable and :omniauthable
   devise :database_authenticatable,
@@ -35,7 +34,7 @@ def status_color
     return 'warning' if role == 'admin'
     return 'danger' if role == 'superadmin'
 
-    return 'primary'
+    'primary'
   end
 
   private
@@ -45,13 +44,16 @@ def setup_new_user
   end
 
   # :nocov:
+  # rubocop:disable Metrics/BlockLength
   rails_admin do
     weight 10
     navigation_icon 'fa fa-user-circle'
 
     configure :role do
       pretty_value do # used in list view columns and show views, defaults to formatted_value for non-association fields
-        bindings[:view].content_tag(:span, User.human_attribute_name(value), class: "label label-#{bindings[:object].status_color}")
+        bindings[:view].tag.span(
+          User.human_attribute_name(value), class: "label label-#{bindings[:object].status_color}"
+        )
       end
       export_value do
         User.human_attribute_name(value)
@@ -60,7 +62,7 @@ def setup_new_user
 
     configure :email do
       pretty_value do
-        bindings[:view].link_to(value, 'mailto:' + value)
+        bindings[:view].link_to(value, "mailto:#{value}")
       end
       export_value do
         value
@@ -94,5 +96,6 @@ def setup_new_user
       field :last_sign_in_at
     end
   end
+  # rubocop:enable Metrics/BlockLength
   # :nocov:
 end

config/application.rb

@@ -42,8 +42,5 @@ class Application < Rails::Application
     # Skip views, helpers and assets when generating a new resource.
 
     config.time_zone = 'Berlin'
-
-
-
   end
 end

config/environments/development.rb

@@ -51,7 +51,6 @@
   # Use an evented file watcher to asynchronously detect changes in source code,
   # routes, locales, etc. This feature depends on the listen gem.
   config.file_watcher = ActiveSupport::EventedFileUpdateChecker
-  
-  config.action_mailer.default_url_options = { host: ENV['DEFAULT_URL'] }
 
+  config.action_mailer.default_url_options = { host: ENV['DEFAULT_URL'] }
 end

config/initializers/generators.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.config.generators do |g|
   g.orm :active_record, primary_key_type: :uuid
   g.orm :active_record, foreign_key_type: :uuid

config/initializers/locale.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Whitelist locales available for the application
 I18n.available_locales = %i[en de]
 

config/initializers/rails_admin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RailsAdmin.config do |config|
   ### Popular gems integration