getRowHeight in aggrid

[aersam]

Hi there!

I would like to be able to use the getRowHeight Callback in aggrid. In order to implement this I thought about a Python Class wrapping a JavaScript Function constructor. The server would pass the Python object and in JS it would be turned into a Function constructor.

Python:

ui.aggrid(
{                
       "columnDefs": [
             {
                "getRowHeight": JSFunction("params", "return params.data.myCol == 1 ? 50: 20"),
...
}])

JS:

      for (const col in Object.values(this.gridOptions.columnDefs)) {
        col["getRowHeight"] = get_js_func(col["getRowHeight"])
      }

...
}

Would also do a PR :) I think the JSFunction concept would be meaningful in other places, too

[falkoschindler]

Thanks for the suggestion, @aersam!
I wonder, what would be the advantage over the approach we used for ui.table (e.g. in the sorting and formatting demo)?

columns = [
    {
        ...
        ':sort': '(a, b, rowA, rowB) => b.length - a.length',
    },
    {
        ...
        ':format': 'value => value + " years"',
    },
]

[aersam]

Ah yes, no advantage, sorry! I just did not know about this feature, sorry! thanks a lot!

[aersam]

Would that work already with getRowHeight in aggrid?

[falkoschindler]

No, it's not yet implemented. Here is the corresponding feature request: #1420.

[aersam]

Ok, here's the pull request for it: #1470 :)

[falkoschindler]

Dynamic properties for ui.aggrid have been released in version 1.3.12.
A demo using getRowHeight will be deployt to the documentation page shortly.

[rodja]

It's now live at https://nicegui.io/documentation/aggrid#ag_grid_with_dynamic_row_height