Skip to content

Commit 3754da6

Browse files
committed
final
1 parent fdcf471 commit 3754da6

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

lib/activerecord-import/adapters/mysql_adapter.rb

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def insert_many( sql, values, options = {}, *args ) # :nodoc:
3939
number_of_inserts += 1
4040
sql2insert = base_sql + values.join( ',' ) + post_sql
4141
result = execute( sql2insert, *args )
42-
if result&.respond_to?(:affected_rows)
42+
if result.respond_to?(:affected_rows)
4343
affected_rows = (affected_rows || 0) + result.affected_rows
4444
end
4545
else
@@ -52,9 +52,9 @@ def insert_many( sql, values, options = {}, *args ) # :nodoc:
5252
number_of_inserts += 1
5353
sql2insert = base_sql + value_set.join( ',' ) + post_sql
5454
result = execute( sql2insert, *args )
55-
if result&.respond_to?(:affected_rows)
56-
affected_rows = (affected_rows || 0) + result.affected_rows
57-
end
55+
if result.respond_to?(:affected_rows)
56+
affected_rows = (affected_rows || 0) + result.affected_rows
57+
end
5858
end
5959
end
6060
end
@@ -141,5 +141,4 @@ def increment_locking_column!(table_name, results, locking_column)
141141
results << "`#{locking_column}`=#{table_name}.`#{locking_column}`+1"
142142
end
143143
end
144-
145144
end

lib/activerecord-import/import.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -862,11 +862,7 @@ def import_without_validations_or_callbacks( conn, column_names, array_of_attrib
862862
number_inserted += result.num_inserts
863863
ids += result.ids
864864
results += result.results
865-
if result.affected_rows.nil?
866-
affected_rows = nil # Keep nil if adapter doesn't support it
867-
else
868-
affected_rows = (affected_rows || 0) + result.affected_rows
869-
end
865+
affected_rows = result.affected_rows.nil? ? nil : (affected_rows || 0) + result.affected_rows
870866
current_batch += 1
871867

872868
progress_proc.call(import_size, batches, current_batch, Time.now.to_i - batch_started_at) if run_proc

0 commit comments

Comments
 (0)