fix: resolve continue button session ID, pagination title loss, and unicode splitting

- Continue button now uses the session ID embedded in the button instead
  of calling getClaudeSessionId() which could return a different session
- Pagination state now stores the original title and uses it when
  navigating pages instead of hardcoded 'Content'
- splitText now iterates by Unicode code points to prevent breaking
  emoji/surrogate pairs at split boundaries

Resolves audit issues #13, #11, #12

Author: zebbern

discord/bot.ts

@@ -337,13 +337,20 @@ export async function createDiscordBot(
     // Handle continue with session ID pattern: "continue:sessionId"
     if (buttonId.startsWith('continue:')) {
       const sessionId = buttonId.split(':')[1];
-      const continueHandler = buttonHandlers.get('continue');
-      if (continueHandler) {
-        try {
-          await continueHandler(ctx);
-        } catch (error) {
-          console.error(`Error handling continue button:`, error);
-        }
+      try {
+        await ctx.update({
+          embeds: [{
+            color: 0xffff00,
+            title: '\u27a1\ufe0f Continue Session',
+            description: `Use \`/continue\` or \`/claude session_id:${sessionId}\` to continue this conversation.`,
+            fields: [
+              { name: 'Session ID', value: `\`${sessionId}\``, inline: false }
+            ],
+            timestamp: true
+          }]
+        });
+      } catch (error) {
+        console.error(`Error handling continue button:`, error);
       }
       return;
     }

discord/pagination.ts

@@ -18,6 +18,7 @@ export interface PaginationState {
   totalPages: number;
   content: string[];
   options: PaginationOptions;
+  title: string;
   messageId?: string;
 }
 
@@ -203,7 +204,8 @@ export function initializePagination(
     currentPage: 0,
     totalPages: paginatedContent.totalPages,
     content: smartSplit(content, options.pageSize || 4000),
-    options
+    options,
+    title
   };
 
   paginationStates.set(paginationId, paginationState);
@@ -259,7 +261,7 @@ export function handlePaginationInteraction(
 
   // Create new embed for the current page
   const paginatedContent = createPaginatedEmbeds(
-    'Content', // We'll update this with the original title
+    state.title,
     state.content[newPage],
     { ...state.options, includePageInfo: true }
   );
@@ -269,9 +271,9 @@ export function handlePaginationInteraction(
   return {
     embed: {
       ...paginatedContent.embeds[0],
-      title: state.options.includePageInfo 
-        ? `Content (Page ${newPage + 1}/${state.totalPages})`
-        : 'Content'
+      title: state.options.includePageInfo !== false
+        ? `${state.title} (Page ${newPage + 1}/${state.totalPages})`
+        : state.title
     },
     components: buttons.length > 0 ? buttons : undefined
   };

discord/utils.ts

@@ -9,8 +9,22 @@ export function sanitizeChannelName(name: string): string {
 
 export function splitText(text: string, maxLength: number): string[] {
   const chunks: string[] = [];
-  for (let i = 0; i < text.length; i += maxLength) {
-    chunks.push(text.substring(i, i + maxLength));
+  let current = '';
+
+  for (const codePoint of text) {
+    if ((current + codePoint).length > maxLength) {
+      if (current) {
+        chunks.push(current);
+      }
+      current = codePoint;
+    } else {
+      current += codePoint;
+    }
+  }
+
+  if (current) {
+    chunks.push(current);
   }
+
   return chunks;
 }