fix(update): Create an update marker regardless of the update mode

Author: tartarughina

src/debugger.rs

@@ -10,7 +10,7 @@ use zed_extension_api::{
 };
 
 use crate::{
-    config::{CheckUpdates, get_check_updates, get_java_debug_jar},
+    config::get_java_debug_jar,
     lsp::LspWrapper,
     util::{
         create_path_if_not_exists, get_curr_dir, mark_checked_once, path_to_quoted_string,
@@ -124,21 +124,18 @@ impl Debugger {
         }
 
         // Use local installation if update mode requires it
-        if let Some(path) =
-            should_use_local_or_download(configuration, find_latest_local_debugger(), "debugger")?
-        {
+        if let Some(path) = should_use_local_or_download(
+            configuration,
+            find_latest_local_debugger(),
+            DEBUGGER_INSTALL_PATH,
+        )? {
             self.plugin_path = Some(path.clone());
             return Ok(path);
         }
 
-        let result = self.get_or_download_fork(language_server_id);
-
-        // Mark as checked once if in Once mode and download was successful
-        if result.is_ok() && get_check_updates(configuration) == CheckUpdates::Once {
-            let _ = mark_checked_once(DEBUGGER_INSTALL_PATH, "0.53.2");
-        }
+        
 
-        result
+        self.get_or_download_fork(language_server_id)
     }
 
     fn get_or_download_fork(
@@ -169,6 +166,9 @@ impl Debugger {
             format!("Failed to download java-debug fork from {JAVA_DEBUG_PLUGIN_FORK_URL}: {err}")
         })?;
 
+        // Mark the downloaded version for "Once" mode tracking
+        let _ = mark_checked_once(DEBUGGER_INSTALL_PATH, latest_version);
+
         self.plugin_path = Some(jar_path.clone());
         Ok(jar_path)
     }
@@ -270,6 +270,9 @@ impl Debugger {
                 DownloadedFileType::Uncompressed,
             )
             .map_err(|err| format!("Failed to download {url} {err}"))?;
+
+            // Mark the downloaded version for "Once" mode tracking
+            let _ = mark_checked_once(DEBUGGER_INSTALL_PATH, latest_version);
         }
 
         self.plugin_path = Some(jar_path.clone());

src/jdk.rs

@@ -6,12 +6,9 @@ use zed_extension_api::{
     set_language_server_installation_status,
 };
 
-use crate::{
-    config::{CheckUpdates, get_check_updates},
-    util::{
-        get_curr_dir, has_checked_once, mark_checked_once, path_to_quoted_string,
-        remove_all_files_except,
-    },
+use crate::util::{
+    get_curr_dir, mark_checked_once, path_to_quoted_string, remove_all_files_except,
+    should_use_local_or_download,
 };
 
 // Errors
@@ -77,32 +74,10 @@ pub fn try_to_fetch_and_install_latest_jdk(
     let jdk_path = get_curr_dir()?.join(JDK_INSTALL_PATH);
 
     // Check if we should use local installation based on update mode
-    match get_check_updates(configuration) {
-        CheckUpdates::Never => {
-            if let Some(local_path) = find_latest_local_jdk() {
-                return get_jdk_bin_path(&local_path);
-            }
-            return Err(
-                "Update checks disabled (never) and no local JDK installation found".to_string(),
-            );
-        }
-        CheckUpdates::Once => {
-            // If we have a local installation, use it
-            if let Some(local_path) = find_latest_local_jdk() {
-                return get_jdk_bin_path(&local_path);
-            }
-
-            // If we've already checked once, don't check again
-            if has_checked_once(JDK_INSTALL_PATH) {
-                return Err(
-                    "Update check already performed once for JDK. No local installation found."
-                        .to_string(),
-                );
-            }
-        }
-        CheckUpdates::Always => {
-            // Continue to check for updates
-        }
+    if let Some(path) =
+        should_use_local_or_download(configuration, find_latest_local_jdk(), JDK_INSTALL_PATH)?
+    {
+        return get_jdk_bin_path(&path);
     }
 
     let version = zed::latest_github_release(
@@ -145,10 +120,8 @@ pub fn try_to_fetch_and_install_latest_jdk(
         let _ = remove_all_files_except(&jdk_path, version.as_str());
     }
 
-    // Mark as checked once if in Once mode
-    if get_check_updates(configuration) == CheckUpdates::Once {
-        let _ = mark_checked_once(JDK_INSTALL_PATH, &version);
-    }
+    // Always mark the downloaded version for "Once" mode tracking
+    let _ = mark_checked_once(JDK_INSTALL_PATH, &version);
 
     get_jdk_bin_path(&install_path)
 }

src/jdtls.rs

@@ -15,7 +15,7 @@ use zed_extension_api::{
 };
 
 use crate::{
-    config::{CheckUpdates, get_check_updates, is_java_autodownload},
+    config::is_java_autodownload,
     jdk::try_to_fetch_and_install_latest_jdk,
     util::{
         create_path_if_not_exists, get_curr_dir, get_java_exec_name, get_java_executable,
@@ -158,7 +158,7 @@ pub fn try_to_fetch_and_install_latest_jdtls(
 ) -> zed::Result<PathBuf> {
     // Use local installation if update mode requires it
     if let Some(path) =
-        should_use_local_or_download(configuration, find_latest_local_jdtls(), "jdtls")?
+        should_use_local_or_download(configuration, find_latest_local_jdtls(), JDTLS_INSTALL_PATH)?
     {
         return Ok(path);
     }
@@ -205,10 +205,8 @@ pub fn try_to_fetch_and_install_latest_jdtls(
         let _ = remove_all_files_except(prefix, build_directory.as_str());
     }
 
-    // Mark as checked once if in Once mode
-    if get_check_updates(configuration) == CheckUpdates::Once {
-        let _ = mark_checked_once(JDTLS_INSTALL_PATH, &latest_version);
-    }
+    // Always mark the downloaded version for "Once" mode tracking
+    let _ = mark_checked_once(JDTLS_INSTALL_PATH, &latest_version);
 
     // return jdtls base path
     Ok(build_path)
@@ -219,9 +217,11 @@ pub fn try_to_fetch_and_install_latest_lombok(
     configuration: &Option<Value>,
 ) -> zed::Result<PathBuf> {
     // Use local installation if update mode requires it
-    if let Some(path) =
-        should_use_local_or_download(configuration, find_latest_local_lombok(), "lombok")?
-    {
+    if let Some(path) = should_use_local_or_download(
+        configuration,
+        find_latest_local_lombok(),
+        LOMBOK_INSTALL_PATH,
+    )? {
         return Ok(path);
     }
 
@@ -256,10 +256,8 @@ pub fn try_to_fetch_and_install_latest_lombok(
         let _ = remove_all_files_except(prefix, jar_name.as_str());
     }
 
-    // Mark as checked once if in Once mode
-    if get_check_updates(configuration) == CheckUpdates::Once {
-        let _ = mark_checked_once(LOMBOK_INSTALL_PATH, &latest_version);
-    }
+    // Always mark the downloaded version for "Once" mode tracking
+    let _ = mark_checked_once(LOMBOK_INSTALL_PATH, &latest_version);
 
     // else use it
     Ok(jar_path)