Create the update marker only after download

Author: tartarughina

src/jdk.rs

@@ -80,6 +80,12 @@ pub fn try_to_fetch_and_install_latest_jdk(
         return get_jdk_bin_path(&path);
     }
 
+    // Check for updates, if same version is already downloaded skip download
+    set_language_server_installation_status(
+        language_server_id,
+        &LanguageServerInstallationStatus::CheckingForUpdate,
+    );
+
     let version = zed::latest_github_release(
         CORRETTO_REPO,
         zed_extension_api::GithubReleaseOptions {
@@ -91,13 +97,6 @@ pub fn try_to_fetch_and_install_latest_jdk(
 
     let install_path = jdk_path.join(&version);
 
-    // Check for updates, if same version is already downloaded skip download
-
-    set_language_server_installation_status(
-        language_server_id,
-        &LanguageServerInstallationStatus::CheckingForUpdate,
-    );
-
     if !install_path.exists() {
         set_language_server_installation_status(
             language_server_id,
@@ -118,10 +117,10 @@ pub fn try_to_fetch_and_install_latest_jdk(
 
         // Remove older versions
         let _ = remove_all_files_except(&jdk_path, version.as_str());
-    }
 
-    // Always mark the downloaded version for "Once" mode tracking
-    let _ = mark_checked_once(JDK_INSTALL_PATH, &version);
+        // Mark the downloaded version for "Once" mode tracking
+        let _ = mark_checked_once(JDK_INSTALL_PATH, &version);
+    }
 
     get_jdk_bin_path(&install_path)
 }

src/jdtls.rs

@@ -164,6 +164,11 @@ pub fn try_to_fetch_and_install_latest_jdtls(
     }
 
     // Download latest version
+    set_language_server_installation_status(
+        language_server_id,
+        &LanguageServerInstallationStatus::CheckingForUpdate,
+    );
+
     let (last, second_last) = get_latest_versions_from_tag(JDTLS_REPO)?;
 
     let (latest_version, latest_version_build) = download_jdtls_milestone(last.as_ref())
@@ -203,10 +208,10 @@ pub fn try_to_fetch_and_install_latest_jdtls(
 
         // ...and delete other versions
         let _ = remove_all_files_except(prefix, build_directory.as_str());
-    }
 
-    // Always mark the downloaded version for "Once" mode tracking
-    let _ = mark_checked_once(JDTLS_INSTALL_PATH, &latest_version);
+        // Mark the downloaded version for "Once" mode tracking
+        let _ = mark_checked_once(JDTLS_INSTALL_PATH, &latest_version);
+    }
 
     // return jdtls base path
     Ok(build_path)
@@ -254,10 +259,10 @@ pub fn try_to_fetch_and_install_latest_lombok(
         // ...and delete other versions
 
         let _ = remove_all_files_except(prefix, jar_name.as_str());
-    }
 
-    // Always mark the downloaded version for "Once" mode tracking
-    let _ = mark_checked_once(LOMBOK_INSTALL_PATH, &latest_version);
+        // Mark the downloaded version for "Once" mode tracking
+        let _ = mark_checked_once(LOMBOK_INSTALL_PATH, &latest_version);
+    }
 
     // else use it
     Ok(jar_path)