Skip to content

Commit 26d9bdd

Browse files
authored
rust-release: exclude cargo-timing.html from release assets (openai#11564)
## Why The `release` job in `.github/workflows/rust-release.yml` uploads `files: dist/**` via `softprops/action-gh-release`. The downloaded timing artifacts include multiple files with the same basename, `cargo-timing.html` (one per target), which causes release asset collisions/races and can fail with GitHub release-assets API `404 Not Found` errors. ## What Changed - Updated the existing cleanup step before `Create GitHub Release` to remove all `cargo-timing.html` files from `dist/`. - Removed any now-empty directories after deleting those timing files. Relevant change: - https://github.com/openai/codex/blob/daba003d32f299579e9b89240aa8ebdc9f161424/.github/workflows/rust-release.yml#L423 ## Verification - Confirmed from failing release logs that multiple `cargo-timing.html` files were being included in `dist/**` and that the release step failed while operating on duplicate-named assets. - Verified the workflow now deletes those files before the release upload step, so `cargo-timing.html` is no longer part of the release asset set.
1 parent 6ca9b43 commit 26d9bdd

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

.github/workflows/rust-release.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,11 @@ jobs:
424424
run: |
425425
rm -rf dist/shell-tool-mcp*
426426
rm -rf dist/windows-binaries*
427+
# cargo-timing.html appears under multiple target-specific directories.
428+
# If included in files: dist/**, release upload races on duplicate
429+
# asset names and can fail with 404s.
430+
find dist -type f -name 'cargo-timing.html' -delete
431+
find dist -type d -empty -delete
427432
428433
ls -R dist/
429434

0 commit comments

Comments
 (0)