Commit 383e537
authored
Check integrity of webrtc download in build script (#6)
We see periodic failures of zed-industries/zed CI when the `cc` builder
in the `webrtc-sys` build script fails to find some webrtc header files
that are supposed to be downloaded using this function:
https://github.com/zed-industries/livekit-rust-sdks/blob/d2eade7a6b15d6dbdb38ba12a1ff7bf07fcebba4/webrtc-sys/build/src/lib.rs#L179
This downloads a zip from the assets attached to a specific
livekit/rust-sdks release, and unpacks it under OUT_DIR. My guess is
that sometimes the download step fails and produces a corrupt downloaded
zip, without signaling the failure in a way that would stop the build.
This PR tries to fix that by having the download step check the SHA-256
digest of the downloaded zip (using a manually-computed list of good
digests; I'd like to use digests from the GitHub API but the particular
artifacts we download don't have them).
If we confirm that this is the source of the problem, I'll follow up
with a change to retry the download in the build script.1 parent d2eade7 commit 383e537
3 files changed
+58
-5
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
| 29 | + | |
27 | 30 | | |
28 | 31 | | |
29 | 32 | | |
| |||
191 | 194 | | |
192 | 195 | | |
193 | 196 | | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
194 | 226 | | |
195 | 227 | | |
196 | | - | |
| 228 | + | |
| 229 | + | |
197 | 230 | | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
198 | 236 | | |
199 | | - | |
200 | | - | |
201 | | - | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
202 | 246 | | |
203 | | - | |
204 | 247 | | |
205 | 248 | | |
206 | 249 | | |
| |||
0 commit comments