check webrtc download

Author: cole-miller

Cargo.lock

@@ -7,9 +7,17 @@ description = "Build utilities when working with libwebrtc"
 repository = "https://github.com/livekit/client-sdk-rust"
 
 [dependencies]
-reqwest = { version = "0.11", default-features = false, features = ["rustls-tls-native-roots", "blocking"] }
+reqwest = { version = "0.11", default-features = false, features = [
+    "rustls-tls-native-roots",
+    "blocking",
+    "json",
+] }
+serde = { "version" = "1.0.219", features = ["derive"] }
 zip = "0.6"
 regex = "1.0"
 scratch = "1.0"
 fs2 = "0.4"
 semver = "1.0"
+sha2 = "0.10"
+base16 = "0.2.1"
+defer = 

webrtc-sys/build/Cargo.toml

@@ -24,9 +24,10 @@ use std::{
 use fs2::FileExt;
 use regex::Regex;
 use reqwest::StatusCode;
+use sha2::{Digest, Sha256};
 
 pub const SCRATH_PATH: &str = "livekit_webrtc";
-pub const WEBRTC_TAG: &str = "webrtc-b99fd2c-6";
+pub const WEBRTC_TAG: &str = "webrtc-ed96590";
 pub const IGNORE_DEFINES: [&str; 2] = ["CR_CLANG_REVISION", "CR_XCODE_VERSION"];
 
 pub fn target_os() -> String {
@@ -84,23 +85,14 @@ pub fn custom_dir() -> Option<path::PathBuf> {
 
 /// Location of the downloaded webrtc binaries
 pub fn prebuilt_dir() -> path::PathBuf {
-    let target_dir = PathBuf::from(std::env::var("OUT_DIR").unwrap());
-    path::Path::new(&target_dir).join(format!(
+    PathBuf::from(std::env::var("OUT_DIR").unwrap()).join(format!(
         "livekit/{}-{}/{}",
         webrtc_triple(),
         WEBRTC_TAG,
         webrtc_triple()
     ))
 }
 
-pub fn download_url() -> String {
-    format!(
-        "https://github.com/livekit/client-sdk-rust/releases/download/{}/{}.zip",
-        WEBRTC_TAG,
-        format!("webrtc-{}", webrtc_triple())
-    )
-}
-
 /// Used location of libwebrtc depending on whether it's a custom build or not
 pub fn webrtc_dir() -> path::PathBuf {
     if let Some(path) = custom_dir() {
@@ -177,31 +169,97 @@ pub fn configure_jni_symbols() -> Result<(), Box<dyn Error>> {
 }
 
 pub fn download_webrtc() -> Result<(), Box<dyn Error>> {
-    let dir = scratch::path(SCRATH_PATH);
-    let flock = File::create(dir.join(".lock"))?;
-    flock.lock_exclusive()?;
+    fn inner() -> Result<(), Box<dyn Error>> {
+        let dir = scratch::path(SCRATH_PATH);
+        let flock = File::create(dir.join(".lock"))?;
+        flock.lock_exclusive()?;
+
+        let webrtc_dir = webrtc_dir();
+        if webrtc_dir.exists() {
+            return Ok(());
+        }
 
-    let webrtc_dir = webrtc_dir();
-    if webrtc_dir.exists() {
-        return Ok(());
-    }
+        #[derive(Debug, serde::Deserialize)]
+        struct Asset {
+            name: String,
+            browser_download_url: String,
+            digest: Option<String>,
+        }
 
-    let mut resp = reqwest::blocking::get(download_url())?;
-    if resp.status() != StatusCode::OK {
-        return Err(format!("failed to download webrtc: {}", resp.status()).into());
-    }
+        #[derive(Debug, serde::Deserialize)]
+        struct Release {
+            assets: Vec<Asset>,
+        }
 
-    let tmp_path = env::var("OUT_DIR").unwrap() + "/webrtc.zip";
-    let tmp_path = path::Path::new(&tmp_path);
-    let mut file = fs::File::options().write(true).read(true).create(true).open(tmp_path)?;
-    resp.copy_to(&mut file)?;
+        let tmp_path = env::var("OUT_DIR").unwrap() + "/webrtc.zip";
+        let tmp_path = path::Path::new(&tmp_path);
+        let mut error = None;
 
-    let mut archive = zip::ZipArchive::new(file)?;
-    archive.extract(webrtc_dir.parent().unwrap())?;
-    drop(archive);
+        let mut attempt = 0;
+        let file = loop {
+            attempt += 1;
+            if attempt > 5 {
+                return Err(error.unwrap_or_else(|| "failed to download webrtc".to_owned().into()));
+            }
 
-    fs::remove_file(tmp_path)?;
-    Ok(())
+            let mut file = fs::File::options()
+                .write(true)
+                .read(true)
+                .create(true)
+                .truncate(true)
+                .open(tmp_path)?;
+
+            let client = reqwest::blocking::Client::builder()
+                .user_agent("Zed livekit-rust-sdks build script")
+                .build()?;
+            let release_url = format!(
+                "https://api.github.com/repos/livekit/rust-sdks/releases/tags/{}",
+                WEBRTC_TAG
+            );
+            let release = client.get(release_url).send()?.json::<Release>()?;
+            let name = format!("webrtc-{}.zip", webrtc_triple());
+            let asset = release.assets.iter().find(|asset| asset.name == name).unwrap();
+
+            let mut resp = reqwest::blocking::get(&asset.browser_download_url)?;
+            if resp.status() != StatusCode::OK {
+                let msg = format!("failed to download webrtc: {}", resp.status());
+                println!("cargo:warning={msg}");
+                error = Some(msg.into());
+                continue;
+            }
+
+            resp.copy_to(&mut file)?;
+
+            if let Some(digest) =
+                asset.digest.as_ref().and_then(|digest| digest.strip_prefix("sha256:"))
+            {
+                let content = std::fs::read(tmp_path)?;
+                let found_digest = Sha256::digest(&content);
+                let found_digest = base16::encode_lower(&found_digest);
+                if found_digest != digest {
+                    let msg = "corrupted webrtc download".to_owned();
+                    println!("cargo:warning={msg}");
+                    error = Some(msg.into());
+                    continue;
+                }
+            }
+
+            break file;
+        };
+
+        let mut archive = zip::ZipArchive::new(file)?;
+        archive.extract(webrtc_dir.parent().unwrap())?;
+        drop(archive);
+
+        fs::remove_file(tmp_path)?;
+        Ok(())
+    }
+
+    let result = inner();
+    if result.is_err() {
+        std::fs::remove_dir_all(webrtc_dir()).ok();
+    }
+    result
 }
 
 pub fn android_ndk_toolchain() -> Result<path::PathBuf, &'static str> {