Skip to content

Commit 3e96af3

Browse files
committed
Use libwebrtc's DesktopCapturer for screen capture
This adds support for screen sharing on Wayland (fixes #28754). libwebrtc replaces scap, which aims to be cross platform but was only used on Windows and X11. The X11 support relied on an out-of-tree branch on which the original author closed their own pull request (CapSoftware/scap#124). This also replaces Zed's platform-specific code on macOS. Switching to a single cross platform library simplifies the code by removing the need for Zed to have its own traits for cross platform abstraction.
1 parent 1179e77 commit 3e96af3

File tree

38 files changed

+587
-1653
lines changed

38 files changed

+587
-1653
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ jobs:
4444
run_tests_linux:
4545
if: (github.repository_owner == 'zed-industries' || github.repository_owner == 'zed-extensions')
4646
runs-on: namespace-profile-16x32-ubuntu-2204
47+
env:
48+
CC: clang
49+
CXX: clang++
4750
steps:
4851
- name: steps::checkout_repo
4952
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -123,6 +126,9 @@ jobs:
123126
check_scripts:
124127
if: (github.repository_owner == 'zed-industries' || github.repository_owner == 'zed-extensions')
125128
runs-on: namespace-profile-2x4-ubuntu-2404
129+
env:
130+
CC: clang
131+
CXX: clang++
126132
steps:
127133
- name: steps::checkout_repo
128134
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

.github/workflows/run_tests.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ jobs:
6161
check_style:
6262
if: (github.repository_owner == 'zed-industries' || github.repository_owner == 'zed-extensions')
6363
runs-on: namespace-profile-4x8-ubuntu-2204
64+
env:
65+
CC: clang
66+
CXX: clang++
6467
steps:
6568
- name: steps::checkout_repo
6669
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -130,6 +133,9 @@ jobs:
130133
- orchestrate
131134
if: needs.orchestrate.outputs.run_tests == 'true'
132135
runs-on: namespace-profile-16x32-ubuntu-2204
136+
env:
137+
CC: clang
138+
CXX: clang++
133139
steps:
134140
- name: steps::checkout_repo
135141
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -213,6 +219,9 @@ jobs:
213219
- orchestrate
214220
if: needs.orchestrate.outputs.run_tests == 'true'
215221
runs-on: namespace-profile-16x32-ubuntu-2204
222+
env:
223+
CC: clang
224+
CXX: clang++
216225
steps:
217226
- name: steps::checkout_repo
218227
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -252,6 +261,9 @@ jobs:
252261
- orchestrate
253262
if: needs.orchestrate.outputs.run_tests == 'true'
254263
runs-on: namespace-profile-8x16-ubuntu-2204
264+
env:
265+
CC: clang
266+
CXX: clang++
255267
steps:
256268
- name: steps::checkout_repo
257269
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -292,6 +304,9 @@ jobs:
292304
- orchestrate
293305
if: needs.orchestrate.outputs.run_tests == 'true'
294306
runs-on: namespace-profile-2x4-ubuntu-2404
307+
env:
308+
CC: clang
309+
CXX: clang++
295310
steps:
296311
- name: steps::checkout_repo
297312
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -324,6 +339,9 @@ jobs:
324339
- orchestrate
325340
if: needs.orchestrate.outputs.run_docs == 'true'
326341
runs-on: namespace-profile-8x16-ubuntu-2204
342+
env:
343+
CC: clang
344+
CXX: clang++
327345
steps:
328346
- name: steps::checkout_repo
329347
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -394,6 +412,9 @@ jobs:
394412
- orchestrate
395413
if: needs.orchestrate.outputs.run_action_checks == 'true'
396414
runs-on: namespace-profile-2x4-ubuntu-2404
415+
env:
416+
CC: clang
417+
CXX: clang++
397418
steps:
398419
- name: steps::checkout_repo
399420
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

0 commit comments

Comments
 (0)