Skip to content

Commit 81733d4

Browse files
daydalekCopilot
andauthored
settings_ui: Fix hover popover delay setting's json_path (#53359)
The "Hover Popover → Delay" setting item had its json_path set to "hover_popover_enabled" (copy-paste error from the item above it), introduced in #40739. This caused: - "Copy Link" generating a wrong zed://settings/hover_popover_enabled URL - #hover_popover_delay filter returning no results in settings search - Telemetry reporting delay changes as hover_popover_enabled The pick/write closures were always correct, so the setting itself functioned normally. after the fix, filter works correctly <img width="1793" height="752" alt="image" src="https://github.com/user-attachments/assets/b7c459bf-c0d6-4988-ae87-087e859c6666" /> and the copy link button return the correct result <img width="1787" height="120" alt="image" src="https://github.com/user-attachments/assets/e2184f89-c400-453b-8e7d-f8ef8771e1d6" /> Release Notes: - N/A Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 5a7c099 commit 81733d4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

crates/settings_ui/src/page_data.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1757,7 +1757,7 @@ fn editor_page() -> SettingsPage {
17571757
title: "Delay",
17581758
description: "Time to wait in milliseconds before showing the informational hover box.",
17591759
field: Box::new(SettingField {
1760-
json_path: Some("hover_popover_enabled"),
1760+
json_path: Some("hover_popover_delay"),
17611761
pick: |settings_content| settings_content.editor.hover_popover_delay.as_ref(),
17621762
write: |settings_content, value| {
17631763
settings_content.editor.hover_popover_delay = value;

0 commit comments

Comments
 (0)