extensions_ui: Apply category filter to dev extensions#48954
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @invalid-email-address on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
bot
added
the
first contribution
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @invalid-email-address on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
chenwuji2000-cyber
force-pushed
the
fix/extension-search-category-filter
branch
from
41da3ad to
4f2d170
Compare
cla-bot
bot
added
the
cla-signed
|
@esthertrapadoux Hi, I see your message on discord welcome channel and some github issues. So, I guess you might can help this situation. This PR shows need maintainer to approve. I've tested that this PR fixed the problem. 
|
|
Thank you for the PR! The fix for the search not respecting the category filter for installed extensions has been pulled out into #49183. However, I think the changes made for also applying it to dev extensions make sense, so could we update this PR to be solely about that? |
Dev extensions were not filtered by the category selector (e.g., "Themes", "Languages"). Add `filtered_dev_extension_indices` to track which dev extensions match the active `provides_filter`, and use it in rendering and list count. Co-Authored-By: Claude <noreply@anthropic.com>
chenwuji2000-cyber
force-pushed
the
fix/extension-search-category-filter
branch
from
4c0cd0a to
61d5ce9
Compare
chenwuji2000-cyber
changed the title
Sure~ Changes have made. |
chenwuji2000-cyber
left a comment
chenwuji2000-cyber
left a comment
There was a problem hiding this comment.
learned from it!
Following up on #49183 which fixed the category filter for remote extensions. This PR applies the same category filter logic to **dev extensions**. Previously, dev extensions were always shown regardless of the selected category filter (e.g., "Themes", "Languages"). Changes: - Add `filtered_dev_extension_indices` to track which dev extensions match the active `provides_filter` - Add `dev_extension_matches_provides()` helper to map `ExtensionManifest` fields to `ExtensionProvides` variants - Update `render_extensions()` and list count to use filtered dev extension indices Release Notes: - Fixed extension category filter not applying to dev extensions in the extensions panel. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Marshall Bowers <git@maxdeviant.com>
3 participants
Following up on #49183 which fixed the category filter for remote extensions.
This PR applies the same category filter logic to dev extensions. Previously, dev extensions were always shown regardless of the selected category filter (e.g., "Themes", "Languages").
Changes:
filtered_dev_extension_indicesto track which dev extensions match the activeprovides_filterdev_extension_matches_provides()helper to mapExtensionManifestfields toExtensionProvidesvariantsrender_extensions()and list count to use filtered dev extension indicesRelease Notes: