Skip to content

Commit 7b06845

Browse files
authored
Move SpanStatusExtractor.extract() before OperationListener.onEnd() (open-telemetry#15844)
1 parent b2c97b1 commit 7b06845

File tree

1 file changed

+4
-3
lines changed
  • instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter

1 file changed

+4
-3
lines changed

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/Instrumenter.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,10 @@ private void doEnd(
272272
if (operationListeners == null) {
273273
operationListeners = this.operationListeners;
274274
}
275+
276+
SpanStatusBuilder spanStatusBuilder = new SpanStatusBuilderImpl(span);
277+
spanStatusExtractor.extract(spanStatusBuilder, request, response, error);
278+
275279
if (operationListeners.length != 0) {
276280
if (operationListenerAttributesExtractors.length != 0) {
277281
UnsafeAttributes operationAttributes = new UnsafeAttributes();
@@ -289,9 +293,6 @@ private void doEnd(
289293
}
290294
}
291295

292-
SpanStatusBuilder spanStatusBuilder = new SpanStatusBuilderImpl(span);
293-
spanStatusExtractor.extract(spanStatusBuilder, request, response, error);
294-
295296
if (endTime != null) {
296297
span.end(endTime);
297298
} else {

0 commit comments

Comments
 (0)