Skip to content

Commit fc2fe4e

Browse files
Merge pull request #64 from zeixcom/61-bug-read-doesnt-subscribe-to-source-signal-on-target-component-if-it-is-not-upgraded-yet
bugfix(read): revert implementation of read() back to version 0.13.1
2 parents 297c0e8 + 097a064 commit fc2fe4e

File tree

131 files changed

+551
-681
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

131 files changed

+551
-681
lines changed

docs-src/components/module-tabgroup/module-tabgroup.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import {
33
component,
44
fromEvents,
55
fromSelector,
6+
requireDescendant,
67
setProperty,
78
show,
89
} from '../../..'
9-
import { requireDescendant } from '../../../src/core/dom'
1010

1111
export type ModuleTabgroupProps = {
1212
readonly tabs: HTMLButtonElement[]

docs-src/components/module-todo/module-todo.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {
1313
import type { BasicButtonProps } from '../basic-button/basic-button'
1414
import type { FormCheckboxProps } from '../form-checkbox/form-checkbox'
1515
import '../form-textbox/form-textbox'
16-
import '../form-radiogroup/form-radiogroup'
1716

1817
export type ModuleTodoProps = {
1918
readonly active: HTMLElement[]
@@ -30,6 +29,7 @@ export default component(
3029
const textbox = requireDescendant(el, 'form-textbox')
3130
const template = requireDescendant(el, 'template')
3231
const list = requireDescendant(el, 'ol')
32+
const filter = el.querySelector('form-radiogroup')
3333

3434
return [
3535
// Control todo input form
@@ -64,18 +64,10 @@ export default component(
6464
// Control todo list
6565
first(
6666
'ol',
67-
setAttribute(
68-
'filter',
69-
read(
70-
el,
71-
'form-radiogroup',
72-
target => target?.getSignal('value').get() ?? 'all',
73-
),
74-
),
67+
setAttribute('filter', read(filter, 'value', 'all')),
7568
on('click', (e: Event) => {
7669
const target = e.target as HTMLElement
77-
if (target.localName === 'button')
78-
target.closest('li')!.remove()
70+
if (target.closest('button')) target.closest('li')!.remove()
7971
}),
8072
),
8173

docs-src/pages/api/functions/asBoolean.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
> **asBoolean**(): [`AttributeParser`](../type-aliases/AttributeParser.md)\<`boolean`\>
1010
11-
Defined in: [src/lib/parsers.ts:23](https://github.com/zeixcom/ui-element/blob/62aded0dfd41b132db684ccc25a7494068f0d957/src/lib/parsers.ts#L23)
11+
Defined in: [src/lib/parsers.ts:23](https://github.com/zeixcom/ui-element/blob/297c0e8e040b3880ad85a2bc873523a8086f09a3/src/lib/parsers.ts#L23)
1212

1313
Parse a boolean attribute as an actual boolean value
1414

docs-src/pages/api/functions/asEnum.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
> **asEnum**(`valid`): [`AttributeParser`](../type-aliases/AttributeParser.md)\<`string`\>
1010
11-
Defined in: [src/lib/parsers.ts:83](https://github.com/zeixcom/ui-element/blob/62aded0dfd41b132db684ccc25a7494068f0d957/src/lib/parsers.ts#L83)
11+
Defined in: [src/lib/parsers.ts:83](https://github.com/zeixcom/ui-element/blob/297c0e8e040b3880ad85a2bc873523a8086f09a3/src/lib/parsers.ts#L83)
1212

1313
Parse an attribute as a multi-state value (for examnple: true, false, mixed), defaulting to the first valid option
1414

docs-src/pages/api/functions/asInteger.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
> **asInteger**(`fallback?`): [`AttributeParser`](../type-aliases/AttributeParser.md)\<`number`\>
1010
11-
Defined in: [src/lib/parsers.ts:37](https://github.com/zeixcom/ui-element/blob/62aded0dfd41b132db684ccc25a7494068f0d957/src/lib/parsers.ts#L37)
11+
Defined in: [src/lib/parsers.ts:37](https://github.com/zeixcom/ui-element/blob/297c0e8e040b3880ad85a2bc873523a8086f09a3/src/lib/parsers.ts#L37)
1212

1313
Parse an attribute as as number forced to integer with a fallback
1414

docs-src/pages/api/functions/asJSON.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
> **asJSON**\<`T`\>(`fallback`): [`AttributeParser`](../type-aliases/AttributeParser.md)\<`T`\>
1010
11-
Defined in: [src/lib/parsers.ts:101](https://github.com/zeixcom/ui-element/blob/62aded0dfd41b132db684ccc25a7494068f0d957/src/lib/parsers.ts#L101)
11+
Defined in: [src/lib/parsers.ts:101](https://github.com/zeixcom/ui-element/blob/297c0e8e040b3880ad85a2bc873523a8086f09a3/src/lib/parsers.ts#L101)
1212

1313
Parse an attribute as a JSON serialized object with a fallback
1414

docs-src/pages/api/functions/asNumber.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
> **asNumber**(`fallback?`): [`AttributeParser`](../type-aliases/AttributeParser.md)\<`number`\>
1010
11-
Defined in: [src/lib/parsers.ts:59](https://github.com/zeixcom/ui-element/blob/62aded0dfd41b132db684ccc25a7494068f0d957/src/lib/parsers.ts#L59)
11+
Defined in: [src/lib/parsers.ts:59](https://github.com/zeixcom/ui-element/blob/297c0e8e040b3880ad85a2bc873523a8086f09a3/src/lib/parsers.ts#L59)
1212

1313
Parse an attribute as as number with a fallback
1414

docs-src/pages/api/functions/asString.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
> **asString**(`fallback?`): [`AttributeParser`](../type-aliases/AttributeParser.md)\<`string`\>
1010
11-
Defined in: [src/lib/parsers.ts:71](https://github.com/zeixcom/ui-element/blob/62aded0dfd41b132db684ccc25a7494068f0d957/src/lib/parsers.ts#L71)
11+
Defined in: [src/lib/parsers.ts:71](https://github.com/zeixcom/ui-element/blob/297c0e8e040b3880ad85a2bc873523a8086f09a3/src/lib/parsers.ts#L71)
1212

1313
Parse an attribute as a string with a fallback
1414

docs-src/pages/api/functions/component.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
> **component**\<`P`\>(`name`, `init`, `setup`): `void`
1010
11-
Defined in: [src/component.ts:285](https://github.com/zeixcom/ui-element/blob/62aded0dfd41b132db684ccc25a7494068f0d957/src/component.ts#L285)
11+
Defined in: [src/component.ts:285](https://github.com/zeixcom/ui-element/blob/297c0e8e040b3880ad85a2bc873523a8086f09a3/src/component.ts#L285)
1212

1313
Define a component with its states and setup function (connectedCallback)
1414

docs-src/pages/api/functions/dangerouslySetInnerHTML.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
> **dangerouslySetInnerHTML**\<`P`, `E`\>(`reactive`, `options`): [`Effect`](../type-aliases/Effect.md)\<`P`, `E`\>
1010
11-
Defined in: [src/lib/effects.ts:600](https://github.com/zeixcom/ui-element/blob/62aded0dfd41b132db684ccc25a7494068f0d957/src/lib/effects.ts#L600)
11+
Defined in: [src/lib/effects.ts:600](https://github.com/zeixcom/ui-element/blob/297c0e8e040b3880ad85a2bc873523a8086f09a3/src/lib/effects.ts#L600)
1212

1313
Effect for setting the inner HTML of an element with optional Shadow DOM support.
1414
Provides security options for script execution and shadow root creation.

0 commit comments

Comments
 (0)