fix: Fixed small QA issues, b=no-bug, c=common, compact-mode, split-view, tabs, tests

Author: mr-cheffy

prefs/zen/window-sync.yaml

@@ -2,6 +2,9 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+- name: zen.window-sync.enabled
+  value: true
+
 - name: zen.window-sync.log
   value: false
 

src/zen/common/modules/ZenUIManager.mjs

@@ -1362,7 +1362,7 @@ window.gZenVerticalTabsManager = {
         // Check if name is blank, reset if so
         // Always remove, so we can always rename and if it's empty,
         // it will reset to the original name anyway
-        if (hasChanged) {
+        if (hasChanged || (this._tabEdited.zenStaticLabel && newName)) {
           this._tabEdited.zenStaticLabel = newName;
           gBrowser._setTabLabel(this._tabEdited, newName);
           gZenUIManager.showToast("zen-tabs-renamed");

src/zen/compact-mode/sidebar.inc.css

@@ -12,6 +12,7 @@
   #zen-dragover-background {
     width: calc(100% - var(--zen-toolbox-padding) * 2 - 5px);
     left: unset;
+    transform: translateY(-4px);
   }
 
   #zen-tabbox-wrapper {

src/zen/sessionstore/ZenWindowSync.sys.mjs

@@ -517,7 +517,11 @@ class nsZenWindowSync {
    */
   #moveItemToMatchOriginal(aOriginalItem, aTargetItem, aWindow, { isEssential, isPinned }) {
     const { gBrowser, gZenWorkspaces } = aWindow;
-    const originalSibling = aOriginalItem.previousElementSibling;
+    let originalSibling = aOriginalItem.previousElementSibling;
+    if (originalSibling?.classList.contains("space-fake-collapsible-start")) {
+      // Skip space fake elements.
+      originalSibling = originalSibling.previousElementSibling;
+    }
     let isFirstTab = true;
     if (gBrowser.isTabGroup(originalSibling) || gBrowser.isTab(originalSibling)) {
       isFirstTab =

src/zen/split-view/ZenViewSplitter.mjs

@@ -2133,6 +2133,8 @@ class nsZenViewSplitter extends nsZenDOMOperatedFeature {
       const splitData = this.splitTabs(group.tabs, groupData.gridType, -1);
       if (splitData) {
         splitData.layoutTree = layout;
+      } else {
+        gBrowser.removeTabGroup(group);
       }
     }
 

src/zen/tabs/ZenPinnedTabManager.mjs

@@ -577,8 +577,8 @@ class nsZenPinnedTabManager extends nsZenDOMOperatedFeature {
       }
 
       movingTabs = movingTabs.filter((tab) =>
-        gBrowser.isTabGroupLabel(tab)
-          ? tab.group?.isZenFolder && !tabsTarget && !essentialTabsTarget
+        gBrowser.isTabGroupLabel(tab) && tab.group?.isZenFolder
+          ? !tabsTarget && !essentialTabsTarget
           : true
       );
 

src/zen/tests/mochitests/sandbox/mac_register_font.py

@@ -17,69 +17,69 @@
 
 
 def main():
-    parser = argparse.ArgumentParser()
-    parser.add_argument(
-        "-v",
-        "--verbose",
-        action="store_true",
-        help="print verbose registration failures",
-        default=False,
-    )
-    parser.add_argument(
-        "file", nargs="*", help="font file to register or unregister", default=[]
-    )
-    parser.add_argument(
-        "-u",
-        "--unregister",
-        action="store_true",
-        help="unregister the provided fonts",
-        default=False,
-    )
-    parser.add_argument(
-        "-p",
-        "--persist-user",
-        action="store_true",
-        help="permanently register the font",
-        default=False,
-    )
+  parser = argparse.ArgumentParser()
+  parser.add_argument(
+      "-v",
+      "--verbose",
+      action="store_true",
+      help="print verbose registration failures",
+      default=False,
+  )
+  parser.add_argument(
+      "file", nargs="*", help="font file to register or unregister", default=[]
+  )
+  parser.add_argument(
+      "-u",
+      "--unregister",
+      action="store_true",
+      help="unregister the provided fonts",
+      default=False,
+  )
+  parser.add_argument(
+      "-p",
+      "--persist-user",
+      action="store_true",
+      help="permanently register the font",
+      default=False,
+  )
 
-    args = parser.parse_args()
+  args = parser.parse_args()
 
-    if args.persist_user:
-        scope = CoreText.kCTFontManagerScopeUser
-        scopeDesc = "user"
-    else:
-        scope = CoreText.kCTFontManagerScopeSession
-        scopeDesc = "session"
+  if args.persist_user:
+    scope = CoreText.kCTFontManagerScopeUser
+    scopeDesc = "user"
+  else:
+    scope = CoreText.kCTFontManagerScopeSession
+    scopeDesc = "session"
 
-    failureCount = 0
-    for fontPath in args.file:
-        fontURL = Cocoa.NSURL.fileURLWithPath_(fontPath)
-        (result, error) = register_or_unregister_font(fontURL, args.unregister, scope)
-        if result:
-            print(
-                "%sregistered font %s with %s scope"
-                % (("un" if args.unregister else ""), fontPath, scopeDesc)
-            )
-        else:
-            print(
-                "Failed to %sregister font %s with %s scope"
-                % (("un" if args.unregister else ""), fontPath, scopeDesc)
-            )
-            if args.verbose:
-                print(error)
-            failureCount += 1
+  failureCount = 0
+  for fontPath in args.file:
+    fontURL = Cocoa.NSURL.fileURLWithPath_(fontPath)
+    (result, error) = register_or_unregister_font(fontURL, args.unregister, scope)
+    if result:
+      print(
+          "%sregistered font %s with %s scope"
+          % (("un" if args.unregister else ""), fontPath, scopeDesc)
+      )
+    else:
+      print(
+          "Failed to %sregister font %s with %s scope"
+          % (("un" if args.unregister else ""), fontPath, scopeDesc)
+      )
+      if args.verbose:
+        print(error)
+      failureCount += 1
 
-    sys.exit(failureCount)
+  sys.exit(failureCount)
 
 
 def register_or_unregister_font(fontURL, unregister, scope):
-    return (
-        CoreText.CTFontManagerUnregisterFontsForURL(fontURL, scope, None)
-        if unregister
-        else CoreText.CTFontManagerRegisterFontsForURL(fontURL, scope, None)
-    )
+  return (
+      CoreText.CTFontManagerUnregisterFontsForURL(fontURL, scope, None)
+      if unregister
+      else CoreText.CTFontManagerRegisterFontsForURL(fontURL, scope, None)
+  )
 
 
 if __name__ == "__main__":
-    main()
+  main()