feat: Finish update sidebar notification, b=no-bug, c=common

Author: mr-cheffy

src/zen/common/modules/ZenStartup.mjs

@@ -97,7 +97,6 @@ class ZenStartup {
       // Just in case we didn't get the right size.
       gZenUIManager.updateTabsToolbar();
       this.closeWatermark();
-      checkForZenUpdates();
       this.isReady = true;
     });
   }
@@ -163,6 +162,7 @@ class ZenStartup {
     if (!Services.prefs.getBoolPref('zen.welcome-screen.seen', false)) {
       Services.prefs.setBoolPref('zen.welcome-screen.seen', true);
       Services.prefs.setStringPref('zen.updates.last-build-id', Services.appinfo.appBuildID);
+      Services.prefs.setStringPref('zen.updates.last-version', Services.appinfo.version);
       Services.scriptloader.loadSubScript(
         'chrome://browser/content/zen-components/ZenWelcome.mjs',
         window
@@ -173,6 +173,7 @@ class ZenStartup {
   }
 
   async #createUpdateAnimation() {
+    checkForZenUpdates();
     return await createWindowUpdateAnimation();
   }
 }

src/zen/common/modules/ZenUpdates.mjs

@@ -10,8 +10,8 @@ const ZEN_UPDATE_SHOW = 'zen.updates.show-update-notification';
 
 export default function checkForZenUpdates() {
   const version = Services.appinfo.version;
-  const lastVersion = Services.prefs.getStringPref(ZEN_UPDATE_PREF, version);
-
+  const lastVersion = Services.prefs.getStringPref(ZEN_UPDATE_PREF, '');
+  Services.prefs.setStringPref(ZEN_UPDATE_PREF, version);
   if (
     version !== lastVersion &&
     !gZenUIManager.testingEnabled &&

src/zen/common/styles/zen-single-components.css

@@ -622,3 +622,8 @@ body > #confetti {
     display: none;
   }
 }
+
+/* Sidebar notification */
+:root:not([zen-sidebar-expanded='true']) zen-sidebar-notification {
+  display: none;
+}

surfer.json

@@ -19,7 +19,7 @@
       "brandShortName": "Zen",
       "brandFullName": "Zen Browser",
       "release": {
-        "displayVersion": "1.17.8b",
+        "displayVersion": "1.17.9b",
         "github": {
           "repo": "zen-browser/desktop"
         },