Sometimes when closing tabs with middle click it will move back workspace and open tabs.

[scarcekoi]

This is happening on the tabs sidebar (on the left).

[dosubot[bot]]

Hey @scarcekoi, I'm here to help you with any bugs, questions, or contributions. Let me know how I can assist you! Dosu

I found a similar open issue regarding workspace switch animations when opening or closing tabs, but no solution has been found in the comments yet. You can view the issue here ^[1].

Regarding your issue, there are several components and conditions in the codebase that could potentially cause workspace switches when closing tabs. The ZenTabsObserver and ZenTabUnloader classes handle tab events, including TabClose, which might interfere with the default behavior ^[2][3]. Additionally, certain flags like shouldOpenNewTabIfLastUnpinnedTabIsClosed and zenPinnedTabCloseShortcutBehavior can influence tab and workspace behavior when closing tabs ^[4][5].

These components and flags might be contributing to the unexpected workspace switching you're experiencing.

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other}

[dosubot[bot]]

The behavior you're experiencing when holding the middle-click in the empty space below the new tab option might be related to how the event handling is configured for middle-click actions. The gZenVerticalTabsManager object and the ZenViewSplitter component could be involved in this behavior, as they handle middle-click events and workspace interactions.

To address this, you might want to check the zen.tabs.newtab-on-middle-click preference in the browser's configuration settings. Disabling this preference could potentially alter the behavior. You can access these settings by typing about:config in the address bar, then searching for zen.tabs.newtab-on-middle-click to toggle its value ^[1].

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other}

[scarcekoi]

@dosu browser.tabs.opentabfor.middleclick seemed to help.

[dosubot[bot]]

Hey @scarcekoi! I'm glad to hear that browser.tabs.opentabfor.middleclick seemed to help. If you have any more technical questions or need help with bugs, feel free to ask. If you think I should have more info on this, you can always reach out to the Dosu Team. 😊

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other}

[scarcekoi]

Apparently it was my mouse's scroll wheel tilting left whenever I scrolled.

[scarcekoi]

@dosu How can I make the scroll left and scroll right on my mouse wheel not affect the workspaces?

[dosubot[bot]]

To prevent the scroll left and scroll right on your mouse wheel from affecting the workspaces, you can modify the event listener for the 'wheel' event in the ZenWorkspaces class. Specifically, you need to ensure that horizontal scrolls (event.deltaX) do not trigger workspace changes. You can achieve this by adding a condition to ignore horizontal scrolls.

Here's the relevant part of the code that handles the wheel event:

toolbox.addEventListener('wheel', async (event) => {
  if (!this.workspaceEnabled) return;

  // Only process non-gesture scrolls
  if (event.deltaMode !== 1) return;

  const isVerticalScroll = event.deltaY && !event.deltaX;
  const isHorizontalScroll = event.deltaX && !event.deltaY;

  // Ignore horizontal scrolls
  if (isHorizontalScroll) return;

  // If the scroll is vertical, this checks that a modifier key is used before proceeding
  if (isVerticalScroll) {
    const activationKeyMap = {
      ctrl: event.ctrlKey,
      alt: event.altKey,
      shift: event.shiftKey,
      meta: event.metaKey,
    };

    if (this.activationMethod in activationKeyMap && !activationKeyMap[this.activationMethod]) {
      return;
    }
  }

  const currentTime = Date.now();
  if (currentTime - this._lastScrollTime < scrollCooldown) return;

  const delta = isVerticalScroll ? event.deltaY : event.deltaX;
  if (Math.abs(delta) < scrollThreshold) return;

  let direction = delta > 0 ? 1 : -1;
  if (this.naturalScroll) {
    direction = delta > 0 ? -1 : 1;
  }

  const workspaces = (await this._workspaces()).workspaces;
  const currentIndex = workspaces.findIndex(w => w.uuid === this.activeWorkspace);
  if (currentIndex === -1) return;

  let targetIndex = currentIndex + direction;

  if (this.shouldWrapAroundNavigation) {
    targetIndex = (targetIndex + workspaces.length) % workspaces.length;
  } else {
    targetIndex = Math.max(0, Math.min(workspaces.length - 1, targetIndex));
  }

  if (targetIndex !== currentIndex) {
    await this.changeWorkspace(workspaces[targetIndex]);
  }

  this._lastScrollTime = currentTime;
}, { passive: true });

By adding if (isHorizontalScroll) return;, you ensure that horizontal scrolls do not affect the workspaces ^[1].

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other}

[scarcekoi]

@dosu how can I fix that?

[dosubot[bot]]

To fix the issue where the scroll left and scroll right on your mouse wheel affect the workspaces, you can modify the behavior by adjusting the scroll event handling in the ZenWorkspaces class. Specifically, ensure that horizontal scrolls do not trigger workspace changes unless a specific condition is met, such as a modifier key being pressed.

Here's a code snippet that shows how you can modify the _setupSidebarHandlers method to include a check for a modifier key when handling horizontal scrolls:

toolbox.addEventListener('wheel', async (event) => {
  if (!this.workspaceEnabled) return;

  // Only process non-gesture scrolls
  if (event.deltaMode !== 1) return;

  const isVerticalScroll = event.deltaY && !event.deltaX;
  const isHorizontalScroll = event.deltaX && !event.deltaY;

  // Check for a modifier key for horizontal scrolls
  if (isHorizontalScroll) {
    const activationKeyMap = {
      ctrl: event.ctrlKey,
      alt: event.altKey,
      shift: event.shiftKey,
      meta: event.metaKey,
    };

    if (this.activationMethod in activationKeyMap && !activationKeyMap[this.activationMethod]) {
      return;
    }
  }

  const currentTime = Date.now();
  if (currentTime - this._lastScrollTime < scrollCooldown) return;

  // Decide which delta to use
  const delta = isVerticalScroll ? event.deltaY : event.deltaX;
  if (Math.abs(delta) < scrollThreshold) return;

  // Determine scroll direction
  let direction = delta > 0 ? 1 : -1;
  if (this.naturalScroll) {
    direction = delta > 0 ? -1 : 1;
  }

  // Workspace logic
  const workspaces = (await this._workspaces()).workspaces;
  const currentIndex = workspaces.findIndex(w => w.uuid === this.activeWorkspace);
  if (currentIndex === -1) return; // No valid current workspace

  let targetIndex = currentIndex + direction;

  if (this.shouldWrapAroundNavigation) {
    // Add length to handle negative indices and loop
    targetIndex = (targetIndex + workspaces.length) % workspaces.length;
  } else {
    // Clamp within bounds to disable looping
    targetIndex = Math.max(0, Math.min(workspaces.length - 1, targetIndex));
  }

  if (targetIndex !== currentIndex) {
    await this.changeWorkspace(workspaces[targetIndex]);
  }

  this._lastScrollTime = currentTime;
}, { passive: true });

This modification ensures that horizontal scrolls only affect workspaces when a specific modifier key is pressed, preventing unintended workspace changes. Adjust the activationMethod preference to the desired modifier key (e.g., 'ctrl', 'alt', 'shift', or 'meta') ^[1].

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other}