Merge pull request #745 from zendesk/melreal/fix-requester

fix: show requester name when empty string alias

Author: melzreal

assets/request-list-bundle.js

@@ -180,6 +180,15 @@ describe("RequestsTableCell", () => {
         screen.getAllByText("Baby", { exact: false })[0]
       ).toBeInTheDocument();
     });
+
+    test("renders requester name when alias is empty", () => {
+      const userWithEmptyAlias = { ...mockAliasUser, alias: "" };
+      renderCell({ identifier: "requester", user: userWithEmptyAlias });
+
+      expect(
+        screen.getAllByText("Paolo", { exact: false })[0]
+      ).toBeInTheDocument();
+    });
   });
 
   describe("Custom field rendering", () => {

src/modules/request-list/components/requests-table/requests-table-row/RequestsTableCell.test.tsx

@@ -179,7 +179,7 @@ The same applies for the description. */
   }
 
   if (identifier === "requester") {
-    const nameOrAlias = user?.alias === undefined ? user?.name : user?.alias;
+    const nameOrAlias = user?.alias || user?.name;
 
     return (
       <TruncatedTableCell identifier={identifier}>