Fix translations on windows #682
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I cannot mention @zendesk/vikings as recommended here. |
This change is needed during `yarn i18n:update-translations`. Otherwise the translation files are placed in src/modules/undefined.
During `yarn start`: Without this change the translations are not correctly identified and too many bundles are created resulting in error messages: ``` Error: InvalidTemplates - Template(s) with syntax error(s) Validation error Zendesk.Theme/templates/assets.hbs Mapping has more items than allowed. ```
peer-jslater
force-pushed
the
fix-translations-on-windows
branch
from
da0c96e to
6bd68a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When developing on windows multiple problems arose because the theme did not seem to build.
The issue with
yarn startwas found on https://support.zendesk.com/hc/en-us/requests/13811934.So that may already be in Zendesk's backlog/workflow somewhere. I've included my implementation of the fix in this PR.
Another issue occurred when I ran
i18n:update-translationsthat's fixed here. See the commit message for details.I wanted Zendesk to be aware of the problem and my fixes to hopefully save them some time. Here it is.
Screenshots
Checklist
I do not have a mobile device to test on and cannot test on all browsers. So I will not be finishing the checklist.