Standard: Fix Layout offenses

Author: bquorning

.standard_todo.yml

@@ -2,31 +2,16 @@
 # Remove from this list as you refactor files.
 ---
 ignore:
-- lib/migration_tools.rb:
-  - Layout/SpaceInsideArrayLiteralBrackets
 - lib/migration_tools/migration_extension.rb:
-  - Layout/EmptyLinesAroundModuleBody
   - Lint/RedundantStringCoercion
   - Style/HashSyntax
 - lib/migration_tools/tasks.rb:
-  - Layout/MultilineMethodCallBraceLayout
   - Style/HashSyntax
-  - Layout/SpaceInsideArrayLiteralBrackets
-  - Layout/IndentationWidth
-  - Layout/ElseAlignment
-  - Layout/EndAlignment
   - Style/TernaryParentheses
   - Style/StringLiteralsInInterpolation
-  - Layout/SpaceInsideStringInterpolation
-  - Layout/SpaceAroundOperators
-- migration_tools.gemspec:
-  - Layout/ExtraSpacing
 - test/helper.rb:
   - Lint/NonDeterministicRequireOrder
-  - Layout/SpaceInsideBlockBraces
 - test/test_migration_tools.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideArrayLiteralBrackets
   - Style/RedundantBegin
   - Style/EvalWithLocation
-  - Layout/SpaceInsideBlockBraces

lib/migration_tools.rb

@@ -15,5 +15,5 @@ def self.forced!
     @forced = true
   end
 
-  MIGRATION_GROUPS = [ "before", "during", "after", "change" ]
+  MIGRATION_GROUPS = ["before", "during", "after", "change"]
 end

lib/migration_tools/migration_extension.rb

@@ -1,6 +1,5 @@
 module MigrationTools
   module MigrationExtension
-
     attr_accessor :migration_group
 
     def group(arg = nil)

lib/migration_tools/tasks.rb

@@ -46,8 +46,7 @@ def migrate_up(migrations, target_version)
         ActiveRecord::Migrator.new(:up, migrations,
           ActiveRecord::Base.connection.schema_migration,
           ActiveRecord::Base.connection.internal_metadata,
-          target_version
-        )
+          target_version)
       else
         ActiveRecord::Migrator.new(:up, migrations, ActiveRecord::SchemaMigration, target_version)
       end
@@ -71,7 +70,7 @@ def define_migrate_list
             else
               notify "You have #{pending_migrations.size} pending migrations", group
               pending_migrations.each do |migration|
-                notify "  %4d %s %s" % [ migration.version, migration.migration_group.to_s[0..5].center(6), migration.name ]
+                notify "  %4d %s %s" % [migration.version, migration.migration_group.to_s[0..5].center(6), migration.name]
               end
             end
           end
@@ -94,10 +93,10 @@ def define_migrate_group
               end
 
               schema_format = if ActiveRecord::VERSION::MAJOR >= 7
-                                ActiveRecord.schema_format
-                              else
-                                ActiveRecord::Base.schema_format
-                              end
+                ActiveRecord.schema_format
+              else
+                ActiveRecord::Base.schema_format
+              end
 
               Rake::Task["db:schema:dump"].invoke if schema_format == :ruby
               Rake::Task["db:structure:dump"].invoke if schema_format == :sql
@@ -110,10 +109,10 @@ def define_migrate_group
     def define_convenience_tasks
       namespace :db do
         namespace :migrate do
-          [ :list, :group ].each do |ns|
+          [:list, :group].each do |ns|
             namespace ns do
               MigrationTools::MIGRATION_GROUPS.each do |migration_group|
-                desc "#{ns == :list ? 'Lists' : 'Executes' } the migrations for group #{migration_group}"
+                desc "#{ns == :list ? 'Lists' : 'Executes'} the migrations for group #{migration_group}"
                 task migration_group => :environment do
                   self.group = migration_group.to_s
                   Rake::Task["db:migrate:#{ns}"].invoke
@@ -144,7 +143,7 @@ def notify(string, group = "")
       if group.empty?
         puts string
       else
-        puts string + " for group \""+group+"\""
+        puts "#{string} for group \"#{group}\""
       end
     end
   end

migration_tools.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new "migration_tools", "1.9.0" do |s|
   s.description = "Rake tasks for Rails that add groups to migrations"
-  s.summary  = "Encourage migrations that do not require downtime"
+  s.summary = "Encourage migrations that do not require downtime"
   s.homepage = "https://github.com/zendesk/migration_tools"
   s.email = "[email protected]"
   s.authors = ["Morten Primdahl"]

test/helper.rb

@@ -11,6 +11,6 @@
 
 dir = File.expand_path("../migrations", __FILE__)
 ActiveRecord::Migrator.migrations_paths.replace([dir])
-Dir.glob(File.join(dir, "*.rb")).each {|f| require f}
+Dir.glob(File.join(dir, "*.rb")).each { |f| require f }
 
 ActiveRecord::Migration.verbose = false

test/test_migration_tools.rb

@@ -17,7 +17,7 @@
   end
 
   def migrations
-    [ Alpha, Beta, Delta, Kappa ]
+    [Alpha, Beta, Delta, Kappa]
   end
 
   def proxies
@@ -34,9 +34,9 @@ def migration_proxy(m)
   end
 
   it "grouping" do
-    assert_equal [ Alpha, Beta ], migrations.select { |m| m.migration_group == "before" }
-    assert_equal [ Delta ], migrations.select { |m| m.migration_group == "change" }
-    assert_equal [ Kappa ], migrations.select { |m| m.migration_group.nil? }
+    assert_equal [Alpha, Beta], migrations.select { |m| m.migration_group == "before" }
+    assert_equal [Delta], migrations.select { |m| m.migration_group == "change" }
+    assert_equal [Kappa], migrations.select { |m| m.migration_group.nil? }
   end
 
   it "runtime_checking" do
@@ -81,7 +81,7 @@ def migration_proxy(m)
   end
 
   it "migrate_list_without_pending_without_group" do
-    0.upto(3).each {|i| @task.migrator(i).run}
+    0.upto(3).each { |i| @task.migrator(i).run }
 
     @task.expects(:notify).with("Your database schema is up to date", "").once