Skip to content

Commit 8114f31

Browse files
authored
Merge pull request #36 from zendesk/nony--cleanup-ci
Drop Ruby 2.4 and make CI simpler
2 parents d650ac9 + 8ccf773 commit 8114f31

File tree

2 files changed

+20
-9
lines changed

2 files changed

+20
-9
lines changed

.github/workflows/ci.yml

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,36 @@ jobs:
88
strategy:
99
matrix:
1010
ruby-version:
11-
- 2.4
12-
- 2.5
13-
- 2.6
11+
- '2.5'
12+
- '2.6'
1413
gemfile:
1514
- rails4.2
1615
- rails5.0
1716
- rails5.1
1817
- rails5.2
1918
- rails6.0
2019
- rails6.1
21-
exclude:
22-
- ruby-version: 2.4
23-
gemfile: rails6.0
24-
- ruby-version: 2.4
25-
gemfile: rails6.1
2620
env:
2721
BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
2822
steps:
29-
- uses: zendesk/checkout@v2
23+
- uses: zendesk/checkout@v3
3024
- uses: zendesk/setup-ruby@v1
3125
with:
3226
ruby-version: ${{ matrix.ruby-version }}
3327
bundler-cache: true
3428
- run: bundle exec rake test
29+
30+
specs_successful:
31+
name: Specs passing?
32+
needs: specs
33+
if: always()
34+
runs-on: ubuntu-latest
35+
steps:
36+
- run: |
37+
if ${{ needs.specs.result == 'success' }}
38+
then
39+
echo "All specs pass"
40+
else
41+
echo "Some specs failed"
42+
false
43+
fi

migration_tools.gemspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ Gem::Specification.new "migration_tools", "1.7.0" do |s|
77
s.files = `git ls-files lib`.split("\n")
88
s.license = "Apache-2.0"
99

10+
s.required_ruby_version = '>= 2.5.0'
11+
1012
s.add_runtime_dependency "activerecord", '>= 4.2.0', '< 6.2'
1113

1214
s.add_development_dependency "rake"

0 commit comments

Comments
 (0)