Use the simpler initialization API

Author: dasch

lib/kafka/client.rb

@@ -481,7 +481,7 @@ def delete_topic(name, timeout: 30)
     # @note This is an alpha level API and is subject to change.
     #
     # @example Describing the cleanup policy config of a topic
-    #   kafka = Kafka.new(seed_brokers: ["kafka1:9092"])
+    #   kafka = Kafka.new(["kafka1:9092"])
     #   kafka.describe_topic("my-topic", ["cleanup.policy"])
     #   #=> { "cleanup.policy" => "delete" }
     #

lib/kafka/consumer.rb

@@ -20,7 +20,7 @@ module Kafka
   #
   #     require "kafka"
   #
-  #     kafka = Kafka.new(seed_brokers: ["kafka1:9092", "kafka2:9092"])
+  #     kafka = Kafka.new(["kafka1:9092", "kafka2:9092"])
   #
   #     # Create a new Consumer instance in the group `my-group`:
   #     consumer = kafka.consumer(group_id: "my-group")

lib/kafka/producer.rb

@@ -14,7 +14,7 @@ module Kafka
   # do it for you, e.g.
   #
   #     # Will instantiate Kafka::Client
-  #     kafka = Kafka.new(...)
+  #     kafka = Kafka.new(["kafka1:9092", "kafka2:9092"])
   #
   #     # Will instantiate Kafka::Producer
   #     producer = kafka.producer
@@ -106,12 +106,7 @@ module Kafka
   #     # cluster to auto-create topics.
   #     topic = "random-messages"
   #
-  #     kafka = Kafka.new(
-  #       seed_brokers: brokers,
-  #       client_id: "simple-producer",
-  #       logger: logger,
-  #     )
-  #
+  #     kafka = Kafka.new(brokers, client_id: "simple-producer", logger: logger)
   #     producer = kafka.producer
   #
   #     begin

spec/functional/batch_consumer_spec.rb

@@ -9,7 +9,7 @@
     topic = create_random_topic(num_partitions: 15)
 
     Thread.new do
-      kafka = Kafka.new(seed_brokers: kafka_brokers, client_id: "test")
+      kafka = Kafka.new(kafka_brokers, client_id: "test")
       producer = kafka.producer
 
       messages.each do |i|
@@ -23,7 +23,7 @@
 
     threads = 2.times.map do |thread_id|
       t = Thread.new do
-        kafka = Kafka.new(seed_brokers: kafka_brokers, client_id: "test", logger: logger)
+        kafka = Kafka.new(kafka_brokers, client_id: "test", logger: logger)
         consumer = kafka.consumer(group_id: group_id, offset_retention_time: offset_retention_time)
         consumer.subscribe(topic)
 

spec/functional/client_spec.rb

@@ -10,7 +10,7 @@
 
   example "listing available topics in the cluster" do
     # Use a clean Kafka instance to avoid hitting caches.
-    kafka = Kafka.new(seed_brokers: KAFKA_BROKERS, logger: LOGGER)
+    kafka = Kafka.new(KAFKA_BROKERS, logger: LOGGER)
 
     topics = kafka.topics
 

spec/functional/consumer_group_spec.rb

@@ -6,7 +6,7 @@
     messages = (1..1000).to_a
 
     begin
-      kafka = Kafka.new(seed_brokers: kafka_brokers, client_id: "test")
+      kafka = Kafka.new(kafka_brokers, client_id: "test")
       producer = kafka.producer
 
       messages.each do |i|
@@ -22,7 +22,7 @@
     received_messages = []
 
     consumers = 2.times.map do
-      kafka = Kafka.new(seed_brokers: kafka_brokers, client_id: "test", logger: logger)
+      kafka = Kafka.new(kafka_brokers, client_id: "test", logger: logger)
       consumer = kafka.consumer(group_id: group_id, offset_retention_time: offset_retention_time)
       consumer.subscribe(topic)
       consumer
@@ -60,7 +60,7 @@
     var = ConditionVariable.new
 
     Thread.new do
-      kafka = Kafka.new(seed_brokers: kafka_brokers, client_id: "test")
+      kafka = Kafka.new(kafka_brokers, client_id: "test")
       producer = kafka.producer
 
       messages.each do |i|
@@ -88,7 +88,7 @@
 
     threads = 2.times.map do |thread_id|
       t = Thread.new do
-        kafka = Kafka.new(seed_brokers: kafka_brokers, client_id: "test", logger: logger)
+        kafka = Kafka.new(kafka_brokers, client_id: "test", logger: logger)
         consumer = kafka.consumer(group_id: group_id, offset_retention_time: offset_retention_time)
         consumer.subscribe(topic)
 

spec/fuzz/consumer_group_spec.rb

@@ -10,7 +10,7 @@
   before do
     logger.level = Logger::INFO
 
-    kafka = Kafka.new(seed_brokers: kafka_brokers, logger: logger)
+    kafka = Kafka.new(kafka_brokers, logger: logger)
     producer = kafka.producer(max_buffer_size: num_messages)
 
     messages.each do |i|
@@ -66,7 +66,7 @@
   def start_consumer(group_id, result_queue)
     thread = Thread.new do
       kafka = Kafka.new(
-        seed_brokers: kafka_brokers,
+        kafka_brokers,
         logger: logger,
         socket_timeout: 20,
         connect_timeout: 20,

spec/fuzz/producer_spec.rb

@@ -1,6 +1,6 @@
 describe "Producing a lot of messages with an unreliable cluster", fuzz: true do
   let(:logger) { LOGGER }
-  let(:kafka) { Kafka.new(seed_brokers: kafka_brokers, client_id: "test", logger: logger) }
+  let(:kafka) { Kafka.new(kafka_brokers, client_id: "test", logger: logger) }
   let(:producer) { kafka.producer(max_retries: 20, retry_backoff: 5) }
 
   before do

spec/spec_helper.rb

@@ -69,7 +69,7 @@ def self.included(base)
     base.class_eval do
       let(:logger) { LOGGER }
       let(:kafka_brokers) { KAFKA_BROKERS }
-      let(:kafka) { Kafka.new(seed_brokers: kafka_brokers, client_id: "test", logger: logger) }
+      let(:kafka) { Kafka.new(kafka_brokers, client_id: "test", logger: logger) }
 
       after { kafka.close rescue nil }
     end